cmdmod: fix runas and group in run_chroot #53992
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested a review
from 
|
Hey, thanks for the PR! Do we have any existing chroot tests? This seems like something we'd want to protect against regressions. |
|
There is not unit test for run_chroot, but I will do one for this case. |
|
@aplanas you just need to write test for your changes. But if your willing to go up and beyond that would be greatly appreciated. |
cmcmarrow
added
the
Needs-Testcase
|
ping @cmcmarrow |
waynew
removed
the
Needs-Testcase
|
@aplanas Looks like it's out of date, so perhaps a rebase would be good |
aplanas
force-pushed
the
fix_run_chroot
branch
from
d900035
to
0a007e2
Compare
|
@waynew rebased! |
aplanas
force-pushed
the
fix_run_chroot
branch
from
0a007e2
to
efcbf88
Compare
|
Rebased into master |
aplanas
force-pushed
the
fix_run_chroot
branch
from
efcbf88
to
4d562d7
Compare
aplanas
force-pushed
the
fix_run_chroot
branch
2 times, most recently
from
239caf2
to
2c7b654
Compare
|
@aplanas could you please resolve merge conflicts? |
|
On it |
aplanas
force-pushed
the
fix_run_chroot
branch
3 times, most recently
from
f848d97
to
91d3a2a
Compare
aplanas
force-pushed
the
fix_run_chroot
branch
2 times, most recently
from
219dcce
to
56ee80e
Compare
The parameters runas and group for cmdmod.run() will change the efective user and group before executing the command. But in a chroot environment is expected that the change happends inside the chroot, not outside, as the user and groups are refering to objects that can only exist inside the environment. This patch add the userspec parameter to the chroot command, to change the user in the correct place.
dwoz
approved these changes
Apr 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The parameters runas and group for cmdmod.run() will change the efective
user and group before executing the command. But in a chroot environment is
expected that the change happends inside the chroot, not outside, as the
user and groups are refering to objects that can only exist inside the
environment.
This patch add the userspec parameter to the chroot command, to change
the user in the correct place.