(Backport 53996) Fix kwargs iteration for chroot.call #53997
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aplanas
force-pushed
the
backport_53996
branch
from
ee68c91
to
1503718
Compare
ghost
requested a review
from 
waynew
suggested changes
Aug 28, 2019
aplanas
force-pushed
the
backport_53996
branch
from
1503718
to
1db22de
Compare
Can you clarify what the bug is? |
Ouch. Sure! I updated the commit message
Yes sorry. I extended a bit the explanation. |
aplanas
force-pushed
the
backport_53996
branch
from
1db22de
to
a37a90c
Compare
Ch3LL
approved these changes
Sep 16, 2019
waynew
approved these changes
Sep 18, 2019
|
Just to leave ourselves a comment on this - changing the parameter name isn't a problem since this is an unreleased feature, but we do need to make sure that this goes in with the chroot feature. |
|
Rebased on master as part of #54959 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix a bug during the call of the kwargs parameters for chroot.call(). In the original code the iteration was done only on the keys, but the code expect the key and the value too. Simply adding
.items()fix the issue.Tests written?
Yes
(backport #53996)