Some improvements and fixes to the freezer module #54022
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested a review
from
This was referenced Jul 26, 2019
cmcmarrow
approved these changes
Jul 26, 2019
twangboy
requested changes
Jul 29, 2019
| @@ -190,6 +190,9 @@ def restore(name=None, **kwargs): | |||
| name | |||
| Name of the frozen state. Optional. | |||
|
|
|||
| clean | |||
| In True remove the frozen information YAML from the cache | |||
|
|
|||
There was a problem hiding this comment.
Please add a versionadded comment here for the new parameter. I think it's something like this:
.. version-added:: Sodium
There was a problem hiding this comment.
I have the backport to Neon in #54023, do I need to put Neon just in case?
There was a problem hiding this comment.
I also added the release note in neon
|
Rebased on top of master as part of #54960 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix a bug when the module try to re-create the directory where the package information is stored, and add a new parameter in the restore function to clean the YAML document that contain this information after a successful recovery.
Tests written?
Yes/No