Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[master] Porting #50428 to master #54550

Closed
wants to merge 2 commits into from
Closed

[master] Porting #50428 to master #54550

wants to merge 2 commits into from

Conversation

garethgreenaway
Copy link
Contributor

@garethgreenaway garethgreenaway commented Sep 18, 2019 •
edited
Loading

Porting #50428 to master

@garethgreenaway garethgreenaway requested a review from a team as a code owner September 18, 2019 23:43
@ghost ghost requested a review from Ch3LL September 18, 2019 23:43
@garethgreenaway garethgreenaway changed the title [2019.2.1] Porting #50428 to 2019.2.1 [master] Porting #50428 to master Sep 24, 2019
@garethgreenaway garethgreenaway changed the base branch from 2019.2.1 to master September 24, 2019 22:58
@waynew waynew self-assigned this Oct 17, 2019
@waynew
Copy link
Contributor

waynew commented Oct 17, 2019

We should probably go ahead and combine #53866 with this.

@dwoz dwoz assigned s0undt3ch and unassigned waynew Oct 18, 2019
@s0undt3ch
Copy link
Collaborator

PR is updated/ Requirements have been compiled.

@max-arnold max-arnold mentioned this pull request Dec 19, 2019
Closed
@max-arnold max-arnold mentioned this pull request Dec 28, 2019
Merged
@max-arnold
Copy link
Contributor

@s0undt3ch I combined this PR with the follow-up #53866 and submitted the result as a new PR (coz I can't edit this one).

All tests (except the unrelated unicode sls on Windows) are green, so it is potentially ready for merge: #55749

The only thing missing is that I don't know how to regenerate all the static requirements files. However, I added the jmespath dependency to the corresponding *.in files and the static ones already have it.

@s0undt3ch
Copy link
Collaborator

Superseded by #55749

@s0undt3ch s0undt3ch closed this Dec 29, 2019
@waynew waynew removed the master-port label Feb 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@s0undt3ch s0undt3ch s0undt3ch approved these changes

@Ch3LL Ch3LL Awaiting requested review from Ch3LL

Assignees

@s0undt3ch s0undt3ch

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@garethgreenaway @waynew @s0undt3ch @max-arnold @dwoz