Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[master] Porting #52001 to master #54609

Closed
wants to merge 1 commit into from
Closed

[master] Porting #52001 to master #54609

wants to merge 1 commit into from

Conversation

garethgreenaway
Copy link
Contributor

@garethgreenaway garethgreenaway commented Sep 19, 2019 •
edited
Loading

Porting #52001 to master

@garethgreenaway garethgreenaway requested a review from a team September 19, 2019 00:28
@ghost ghost requested review from waynew and removed request for a team September 19, 2019 00:28
@garethgreenaway garethgreenaway changed the title [2019.2.1] Porting #52001 to 2019.2.1 [master] Porting #52001 to master Sep 24, 2019
@garethgreenaway garethgreenaway changed the base branch from 2019.2.1 to master September 24, 2019 22:46
@max-arnold
Copy link
Contributor

@garethgreenaway I'm not 100% sure, but maybe there is no need to merge this. PR #53167 (unmerged) makes this backport unnecessary: #53167 (comment)

In other words, #52001 was obsoleted by #53167

/CC @aplanas

@aplanas
Copy link
Contributor

aplanas commented Oct 7, 2019

@max-arnold That is right, there is a pending PR to develop. IIUC this is to master. I am fine to closing the one to develop in favor of this one, or I can rebase all my patches on top of master, instead of develop.

How is the transition designed? Is there something that I can do to help from my side?

@waynew
Copy link
Contributor

waynew commented Oct 7, 2019

@aplanas if you'd like to rebase your PR against master that would be 💯

We are planning to migrate all the PRs as we can, but if authors can handle the rebasing themselves that's much preferred (and will make things go much quicker!)

@waynew
Copy link
Contributor

waynew commented Dec 27, 2019

Closing this PR in favor of #53167

@waynew waynew closed this Dec 27, 2019
@waynew waynew removed the master-port label Feb 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waynew waynew Awaiting requested review from waynew

Assignees

@s0undt3ch s0undt3ch

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@garethgreenaway @max-arnold @aplanas @waynew @s0undt3ch