Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[master] Porting #50938 to master #54642

Merged
merged 4 commits into from
Dec 29, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions salt/modules/opkg.py
Original file line number Diff line number Diff line change
Expand Up @@ -1462,3 +1462,21 @@ def owner(*paths, **kwargs): # pylint: disable=unused-argument
if len(ret) == 1:
return next(six.itervalues(ret))
return ret


def version_clean(version):
'''
Clean the version string removing extra data.
There's nothing do to here for nipkg.py, therefore it will always
return the given version.
'''
return version


def check_extra_requirements(pkgname, pkgver):
'''
Check if the installed package already has the given requirements.
There's nothing do to here for nipkg.py, therefore it will always
return True.
'''
return True
12 changes: 12 additions & 0 deletions tests/unit/modules/test_opkg.py
Original file line number Diff line number Diff line change
Expand Up @@ -207,3 +207,15 @@ def test_info_installed(self):
mock = MagicMock(return_value=ret_value)
with patch.dict(opkg.__salt__, {'cmd.run_all': mock}):
self.assertEqual(opkg.info_installed('vim'), expected_dict)

def test_version_clean(self):
'''
Test - Return the information of version_clean
'''
self.assertEqual(opkg.version_clean('1.0.1'), '1.0.1')

def test_check_extra_requirements(self):
'''
Test - Return the information of check_extra_requirements
'''
self.assertEqual(opkg.check_extra_requirements('vim', '1.0.1'), True)