Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple LGPO Fixes #54896

Merged
merged 14 commits into from
Jan 6, 2020
Merged

Multiple LGPO Fixes #54896

merged 14 commits into from
Jan 6, 2020

Conversation

twangboy
Copy link
Contributor

@twangboy twangboy commented Oct 4, 2019

What does this PR do?

Fix issue when comparing integer values in the win_lgpo state module. Integer values weren't being compared and therefore always returning not matching.
Fix some stacktraces that are showing up in Windows logs due to missing virtual functions in some salt utils
Change noisy debug statements in the win_lgpo module to trace statements
Fix issue with incorrect registry type for ScRemoveOption
Reverts changes in 0108bcd that were causing issues with policies where the registry entries didn't match the case in the admx/adml files

What issues does this PR fix or reference?

Found fixing locke issues

Tests written?

Yes

Commits signed with GPG?

Yes

@dwoz
Copy link
Contributor

dwoz commented Oct 10, 2019

re-run full all

@twangboy twangboy changed the title Fix comparing integer values (LGPO) WIP: Multiple LGPO Fixes Oct 16, 2019
@twangboy twangboy requested a review from a team as a code owner October 23, 2019 15:58
@ghost ghost requested a review from Ch3LL October 23, 2019 15:58
@waynew
Copy link
Contributor

waynew commented Oct 31, 2019

@twangboy looks like this needs a bit of a rebase...

@twangboy twangboy changed the title WIP: Multiple LGPO Fixes Multiple LGPO Fixes Nov 25, 2019
@twangboy twangboy force-pushed the fix_win_lgpo branch 4 times, most recently from 7b99e60 to 6b9ad20 Compare January 4, 2020 23:18
@codecov
Copy link

codecov bot commented Jan 4, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@f3f9195). Click here to learn what that means.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #54896   +/-   ##
=========================================
  Coverage          ?   18.76%           
=========================================
  Files             ?      825           
  Lines             ?   176254           
  Branches          ?    37929           
=========================================
  Hits              ?    33059           
  Misses            ?   140553           
  Partials          ?     2642
Flag Coverage Δ
#archlts 18.04% <0%> (?)
#centos7 23.73% <0%> (?)
#proxy 23.77% <0%> (?)
#py2 18.56% <0%> (?)
#py3 18.39% <0%> (?)
#runtests 18.76% <0%> (?)
#ubuntu1604 23.71% <0%> (?)
#zeromq 18.76% <0%> (?)
Impacted Files Coverage Δ
salt/modules/win_lgpo.py 6% <ø> (ø)
salt/utils/win_reg.py 10.5% <0%> (ø)

1 similar comment
@codecov
Copy link

codecov bot commented Jan 4, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@f3f9195). Click here to learn what that means.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #54896   +/-   ##
=========================================
  Coverage          ?   18.76%           
=========================================
  Files             ?      825           
  Lines             ?   176254           
  Branches          ?    37929           
=========================================
  Hits              ?    33059           
  Misses            ?   140553           
  Partials          ?     2642
Flag Coverage Δ
#archlts 18.04% <0%> (?)
#centos7 23.73% <0%> (?)
#proxy 23.77% <0%> (?)
#py2 18.56% <0%> (?)
#py3 18.39% <0%> (?)
#runtests 18.76% <0%> (?)
#ubuntu1604 23.71% <0%> (?)
#zeromq 18.76% <0%> (?)
Impacted Files Coverage Δ
salt/modules/win_lgpo.py 6% <ø> (ø)
salt/utils/win_reg.py 10.5% <0%> (ø)

@dwoz dwoz merged commit 702557f into saltstack:master Jan 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants