(Backport 51956) blockdev: hide blkid errors when are expected #54998
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The function _checkblk is called to detect if the device is already formatted. The first time that we call blkid -o value -s TYPE will will fail, as the device is still not formatted. This patch hide this error from the logs (only the ERROR status, not the stderr output and the retcode), as is an expected error. (cherry picked from commit 504c160)
|
@aplanas Can you please resolve the conflicts here? |
|
The fix is already in master! So this PR is not needed anymore. Closing and thanks for the reviews!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The function _checkblk is called to detect if the device is already
formatted. The first time that we call blkid -o value -s TYPE will
will fail, as the device is still not formatted.
This patch hide this error from the logs (only the ERROR status,
not the stderr output and the retcode), as is an expected error.
Tests written?
No, no change in behavior
(backport #51956, already merged in develop)