(Backport 49037) Fix case where args or kwargs are not specified in loop state #55006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like that one fail in the centos6 test is in 'integration.modules.test_shadow.ShadowModuleTest', where the random users 'tu-XXXX' are expected, but not present in the system. Is this a known error that is addressed somewhere else? Edit: Seems to me that is some side-effect of |
|
These do kind of seem like some flaky test failures we've seen before, @Dowz? |
aplanas
force-pushed
the
backport_49037
branch
from
a148a43
to
2731fc0
Compare
ghost
requested a review
from 
Currently, the m_ret line will error if the loop state definition does not specify values for args or kwargs, because None is neither iterable nor a map. If not specified, those values should be set to an empty list and empty dict. (cherry picked from commit f0c0bd0)
(cherry picked from commit 8cb7937)
aplanas
force-pushed
the
backport_49037
branch
from
593290d
to
03e6519
Compare
dwoz
approved these changes
Dec 5, 2019
|
@aplanas @s0undt3ch They pass now, must be flaky tests. Merging |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport to master of #49037