Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix novaclient api #55050

Merged
merged 6 commits into from
Jan 2, 2020
Merged

Fix novaclient api #55050

merged 6 commits into from
Jan 2, 2020

Conversation

Akm0d
Copy link
Contributor

@Akm0d Akm0d commented Oct 17, 2019

What does this PR do?

Port #49977 to master

@dwoz dwoz requested a review from a team as a code owner December 3, 2019 15:30
@ghost ghost requested a review from twangboy December 3, 2019 15:30
@dwoz
Copy link
Contributor

dwoz commented Dec 5, 2019

@Akm0d The linter is still failing here.

@Akm0d
Copy link
Contributor Author

Akm0d commented Dec 12, 2019

re-run full all

@Akm0d
Copy link
Contributor Author

Akm0d commented Dec 12, 2019

re-run full windows2016

@Akm0d
Copy link
Contributor Author

Akm0d commented Dec 12, 2019

re-run full windows2019

@Akm0d
Copy link
Contributor Author

Akm0d commented Dec 12, 2019

re-run full opensuse15

@Akm0d Akm0d added Needs-Testcase PR needs test cases written, or the issue is about a bug/feature that needs test cases and removed Needs-Testcase PR needs test cases written, or the issue is about a bug/feature that needs test cases labels Dec 12, 2019
salt/utils/openstack/nova.py Outdated Show resolved Hide resolved
salt/utils/openstack/nova.py Outdated Show resolved Hide resolved
salt/utils/openstack/nova.py Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Dec 12, 2019

Codecov Report

Merging #55050 into master will increase coverage by 19.5%.
The diff coverage is 14.29%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #55050      +/-   ##
==========================================
+ Coverage   18.81%    38.3%   +19.5%     
==========================================
  Files         817     1464     +647     
  Lines      178439   260114   +81675     
  Branches    38571    54963   +16392     
==========================================
+ Hits        33560    99618   +66058     
- Misses     142142   149195    +7053     
- Partials     2737    11301    +8564
Flag Coverage Δ
#amazon1 38.3% <14.29%> (?)
#archlts ?
#centos7 ?
#proxy ?
#py2 38.3% <14.29%> (+19.5%) ⬆️
#py3 ?
#runtests 38.3% <14.29%> (+19.5%) ⬆️
#ubuntu1604 ?
#zeromq 38.3% <14.29%> (+19.5%) ⬆️
Impacted Files Coverage Δ
salt/utils/openstack/nova.py 14.66% <0%> (+0.02%) ⬆️
salt/modules/nova.py 77.78% <100%> (+44.98%) ⬆️
salt/transport/frame.py 27.28% <0%> (-50%) ⬇️
salt/modules/dummyproxy_service.py 46.16% <0%> (-35.89%) ⬇️
salt/utils/stringio.py 52.39% <0%> (-28.57%) ⬇️
salt/modules/dummyproxy_pkg.py 38.64% <0%> (-22.72%) ⬇️
salt/ext/six.py 54.84% <0%> (-14.15%) ⬇️
salt/grains/philips_hue.py 58.83% <0%> (-11.76%) ⬇️
salt/executors/docker.py 44.45% <0%> (-11.11%) ⬇️
salt/grains/chronos.py 66.67% <0%> (-11.11%) ⬇️
... and 1195 more

@dwoz
Copy link
Contributor

dwoz commented Jan 2, 2020

2019 windows tests are passing:

05:57:53         OK (total=9282, skipped=1213, passed=8069, failures=0, errors=0)

merging pr

@dwoz dwoz merged commit 92fbbf1 into saltstack:master Jan 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants