Use packaged msgpack #55354
Merged
Use packaged msgpack #55354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested a review
from 
|
re-run full all |
dwoz
requested changes
Nov 19, 2019
Akm0d
force-pushed
the
msgpack
branch
2 times, most recently
from
b24705d
to
dd47818
Compare
Codecov Report
@@ Coverage Diff @@
## master #55354 +/- ##
===========================================
- Coverage 40.05% 18.43% -21.61%
===========================================
Files 1484 816 -668
Lines 261512 174097 -87415
Branches 56214 37405 -18809
===========================================
- Hits 104717 32077 -72640
+ Misses 144600 139454 -5146
+ Partials 12195 2566 -9629
|
|
Cleaned up the history now that it's all green 👍. @dwoz I tried to move as much msgpack logic as possible from salt/payload.py to salt/utils/msgpack.py. If I move much more then the msgpack module starts behaving too differently from the base msgpack module |
waynew
approved these changes
Dec 16, 2019
In most cases, yes, It replaces most |
This commit introduces salt.utils.msgpack modifies all places in the code that either use json or msgpack to use salt.utils.json or salt.utils.msgpack respectively. While this change itself does not have any effect, it is important to allow for centrally dealing with objects that cannot be directly serialied via json or msgpack.
When accessing msgpack.Unpacker, we cannot use salt.utils.msgpack, but we do not have to either.
|
re-run full debian8 |
|
re-run full macosxmojave |
dwoz
approved these changes
Dec 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Separates msgpack changes from #54878
Adds a significant amount of testing to new msgpack module