-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Decide if the source should be actually skipped #55402
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dwoz
requested changes
Dec 6, 2019
dwoz
added
the
Needs-Testcase
PR needs test cases written, or the issue is about a bug/feature that needs test cases
label
Dec 6, 2019
garethgreenaway
removed
the
Needs-Testcase
PR needs test cases written, or the issue is about a bug/feature that needs test cases
label
Jan 8, 2020
garethgreenaway
previously approved these changes
Jan 8, 2020
cmcmarrow
previously approved these changes
Mar 18, 2020
frogunder
previously approved these changes
Mar 24, 2020
@Nate-Watts Black needs to be run on this |
@Nate-Watts Black needs to be run on these changes. |
dwoz
dismissed stale reviews from frogunder, cmcmarrow, and garethgreenaway
via
April 20, 2020 01:44
2f32dff
dwoz
approved these changes
May 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Port of #50742
What issues does this PR fix or reference?
Bugfix. If there is a Debian repo with signed-by option, Salt doesn't show it.
Tests written?
Yes
Commits signed with GPG?
No