Added a support for a global proxy to pip module #55596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested a review
from 
Oloremo
force-pushed
the
55593-pip-global-proxy
branch
2 times, most recently
from
80d07b4
to
a17b393
Compare
s0undt3ch
suggested changes
Dec 12, 2019
salt/modules/pip.py
Outdated
| .. note:: | ||
| If the the Minion has a globaly configured proxy - it will be used | ||
| even if no proxy was set here. To explicitly disable proxy for pip | ||
| you should pass the ``False`` as a value. |
There was a problem hiding this comment.
'you should pass False as'...
Oloremo
force-pushed
the
55593-pip-global-proxy
branch
from
27e471d
to
8f7ef15
Compare
s0undt3ch
reviewed
Dec 12, 2019
There was a problem hiding this comment.
I would also do something like:
elif proxy is not False and config.get('proxy_host') and config.get('proxy_port'):
if config.get('proxy_username') and config.get('proxy_password'):
http_proxy_url = 'http://{proxy_username}:{proxy_password}@{proxy_host}:{proxy_port}'.format(**config)
else:
http_proxy_url = 'http://{proxy_host}:{proxy_port}'.format(**config)
Oloremo
force-pushed
the
55593-pip-global-proxy
branch
from
8f7ef15
to
2619434
Compare
|
@s0undt3ch Very cool, added! |
s0undt3ch
approved these changes
Dec 12, 2019
|
re-run full opensuse15-py2 |
|
re-run full ubuntu1604-py2 |
|
re-run full macosxmojave-py2 |
|
re-run full windows2019-py3 |
|
Nitpick: it is worth documenting that the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Added support for a global Salt proxy to pip module
What issues does this PR fix or reference?
#55593
Previous Behavior
pip module and state doesn't support salt global proxy
New Behavior
pip module and state does support salt global proxy
Tests written?
Yes
Commits signed with GPG?
Yes