Rabbitmq additions master #55767
Merged
Rabbitmq additions master #55767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pylint-inspired layout changes. Also remove empty lines in _safe_output function.
…t. Renamed dicttrim.remove_empty_values to data.filter_falsey as per PR 52499.
…tion"-parameter to using all the parameters that make up the definition.
Refactored upstream_present to remove duplicate code.
…et_upstream, delete_upstream. Pylint-inspired fixes.
Fixed docstring for salt/states/rabbitmq_upstream.py:present
ghost
requested a review
from 
dwoz
approved these changes
Jan 2, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Master port of #53123
What does this PR do?
It adds states (in
states/rabbitmq_upstream.pyand functions (inmodules/rabbitmq.py) to manipulate rabbitMQ upstream definitions.What issues does this PR fix or reference?
None that I'm aware of
Previous Behavior
Unable to add/remove/modify rabbitMQ upstreams.
New Behavior
RabbitMQ upstream definitions can be made
_presentor_absentor manipulated via execution functions.Tests written?
Yes
Commits signed with GPG?
Yes