Fix Windows and macOS requirements handling in setup.py #56099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested a review
from 
s0undt3ch
force-pushed
the
hotfix/requirements
branch
from
1ff8123
to
321c37b
Compare
|
Apple has the same problem. |
|
Which one do we miss? |
s0undt3ch
force-pushed
the
hotfix/requirements
branch
from
3c13244
to
1e7bc8f
Compare
s0undt3ch
changed the title
|
This PR has been updated to take into account both Windows and macOS requirements files |
twangboy
approved these changes
Mar 10, 2020
dwoz
approved these changes
Mar 10, 2020
waynew
approved these changes
Mar 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
See title.