Fix for unless requisite when pip is not installed #56215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested a review
from 
dwoz
changed the title
Ch3LL
suggested changes
Feb 26, 2020
| modulec_path = os.path.join(RUNTIME_VARS.CODE_DIR, '__pycache__', 'pip.pyc') | ||
| else: | ||
| modulec_path = os.path.join(RUNTIME_VARS.CODE_DIR, 'pip.pyc') | ||
| print('*' * 80) |
There was a problem hiding this comment.
do we want to keep these prints here?
There was a problem hiding this comment.
Nope, will resolve this
|
@dwoz I believe this line should start with |
Good catch, thanks! |
Ch3LL
approved these changes
Mar 11, 2020
|
looks like there are some lint failures that need to be cleaned up |
DmitryKuzmenko
approved these changes
Mar 11, 2020
waynew
approved these changes
Mar 11, 2020
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix for #56131
Tests written?
Yes
Commits signed with GPG?
Yes