[master] Porting #52670 to master again

[OrangeDog]

Porting #52670 to master again, because the last one (#54572) got reverted by #56353.

When this is merged, vmware-archive/salt-pack#682 needs reverting.

[waynew]

Ah, boo, looks like needs pre-commit hooks 🙃

[waynew]

🚀

[bryceml]

don't ifup and ifdown set things up according to what's specified in /etc/network/interfaces as opposed to ip link set up which doesn't have anything to do with /etc/network/interfaces ?

This seems like it doesn't keep the same behavior at all if I understand it correctly.

It looks like the reason this was originally introduced was because ubuntu started using netplan by default. I'm pretty sure debian still uses ifupdown by default even on debian 10.

It would probably be more correct to do something like nmcli con up ... or nmcli con down ... if using network manager. I'm not sure how you would get the equivilant on netplan since it only really has netplan apply

[bryceml]

This would break existing use of ifupdown on debian 10, this probably needs a much bigger PR to do the correct thing.

[OrangeDog]

@bryceml if that's true, and nobody noticed on the previous two PRs, it should be tracked with #57541 and related.

[OrangeDog]

It would probably be more correct to do something like nmcli con up ... or nmcli con down ... if using network manager. I'm not sure how you would get the equivilant on netplan since it only really has netplan apply

netplan is a higher-level config management system. The alternative to NetworkManager is systemd-networkd. I don't think there is any CLI other than ip. You just edit the config files and reload.

[sagetherage]

@OrangeDog we want to have a deep discussion on this since likely needs to be bigger than this PR and we need to discuss a broader solution. I am putting it into blocked for now, but I will schedule a planning meeting to dive deeper. I would love your input, I know our US meeting are difficult to attend, but I am open to other ideas the use of other platforms if that is helpful.

[OrangeDog]

I have no particular investment. I just noticed this PR has at least twice already been merged and then lost.

The concept is not difficult. You should be using the recommended commands on each of your supported operating systems and not relying on deprecated and removed packages. You need to work out what they are and then write that code. I think that ip is the default method on every linux OS version you support, but I may be mistaken.

[dwoz]

Closing this due to inactivity. Anyone should feel free to re-open it if they want to see it through to the end in one release cycle.