Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Start checking code with Bandit #59648

Merged
merged 12 commits into from
Mar 3, 2021
Merged

Start checking code with Bandit #59648

merged 12 commits into from
Mar 3, 2021

Commits on Mar 2, 2021

  1. Start checking the salt code base with bandit

    @s0undt3ch
    s0undt3ch committed Mar 2, 2021
    Configuration menu
    Copy the full SHA
    081f458 View commit details
    Browse the repository at this point in the history

  2. Don't run the B701(jinja2_autoescape_false) checks.

    @s0undt3ch
    s0undt3ch committed Mar 2, 2021
    Configuration menu
    Copy the full SHA
    c6af336 View commit details
    Browse the repository at this point in the history

  3. Bandit does not read .bandit when files are passed. 

    See PyCQA/bandit#332
    @s0undt3ch
    s0undt3ch committed Mar 2, 2021
    Configuration menu
    Copy the full SHA
    a3afcf9 View commit details
    Browse the repository at this point in the history

  4. Address Bandit's B602(subprocess_popen_with_shell_equals_true) flagge… 

    …d issue
    @s0undt3ch
    s0undt3ch committed Mar 2, 2021
    Configuration menu
    Copy the full SHA
    21e26dd View commit details
    Browse the repository at this point in the history

  5. Address Bandit's B605(start_process_with_a_shell) flagged issue

    @s0undt3ch
    s0undt3ch committed Mar 2, 2021
    Configuration menu
    Copy the full SHA
    3bf277a View commit details
    Browse the repository at this point in the history

  6. Ignore Bandit's B413(blacklist) regarding PyCrypto 

    The Salt project is aware and only uses PyCrypto as a last resort.
Additionally, see saltstack#30287
    @s0undt3ch
    s0undt3ch committed Mar 2, 2021
    Configuration menu
    Copy the full SHA
    6d4d683 View commit details
    Browse the repository at this point in the history

  7. Ignore Bandit's B402(blacklist) regarding ftplib 

    The choice to use it or not is on the user's hands.
    @s0undt3ch
    s0undt3ch committed Mar 2, 2021
    Configuration menu
    Copy the full SHA
    86d3aca View commit details
    Browse the repository at this point in the history

  8. Ignore Bandit's B103(set_bad_file_permissions) 

    When external authentication is involved, we should allow these systems
to write to salt's bus?
    @s0undt3ch
    s0undt3ch committed Mar 2, 2021
    Configuration menu
    Copy the full SHA
    5750b8f View commit details
    Browse the repository at this point in the history

  9. Address Bandit's B602(subprocess_popen_with_shell_equals_true) on the… 

    … test suite
    @s0undt3ch
    s0undt3ch committed Mar 2, 2021
    Configuration menu
    Copy the full SHA
    6b2bc15 View commit details
    Browse the repository at this point in the history

  10. Ignore Bandit's B413(blacklist) regarding PyCrypto on the test suite

    @s0undt3ch
    s0undt3ch committed Mar 2, 2021
    Configuration menu
    Copy the full SHA
    eae1545 View commit details
    Browse the repository at this point in the history

  11. Fix and migrate tests/integration/modules/test_network.py to PyTest

    @s0undt3ch
    s0undt3ch committed Mar 2, 2021
    Configuration menu
    Copy the full SHA
    6569583 View commit details
    Browse the repository at this point in the history

  12. Fix test_traceroute unit test. 

    Not all calls to `salt.utils.path.which` should return `traceroute`
    @s0undt3ch
    s0undt3ch committed Mar 2, 2021
    Configuration menu
    Copy the full SHA
    206ccbd View commit details
    Browse the repository at this point in the history