[freeze] Add contextvars from site-packages to thin tarball #59981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dwoz
added
3003.1
Aluminium
dwoz
force-pushed
the
issue/freeze/59942
branch
5 times, most recently
from
1b67940
to
9dbee0f
Compare
Ch3LL
suggested changes
Apr 13, 2021
If a contextvars package exists one of the site-packages locations use it for the generated thin tarball. This overrides python's builtin contextvars and allows salt-ssh to work with python <=3.6 even when the master's python is >3.6 (Fixes saltstack#59942)
Without this change, salt-ssh cannot target systems with Python <= 3.6
dwoz
force-pushed
the
issue/freeze/59942
branch
from
9dbee0f
to
de52bda
Compare
Ch3LL
previously approved these changes
Apr 14, 2021
|
looks good other than some test failures on mac |
dwoz
force-pushed
the
issue/freeze/59942
branch
from
d9cab07
to
b59e272
Compare
dwoz
force-pushed
the
issue/freeze/59942
branch
from
b59e272
to
ab8ee22
Compare
s0undt3ch
approved these changes
Apr 15, 2021
|
re-run macos centos |
Ch3LL
approved these changes
Apr 19, 2021
garethgreenaway
approved these changes
Apr 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds contextvars package from site-packages to thin tarball instead of python's builtin contextvars if the contextvars package from pypi is installed. This makes salt-ssh work with targets that have python <3.7
What issues does this PR fix or reference?
Fixes: #59942
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.