update fix bug 60915 parse terraform.tfstate error #61311
Conversation
|
Hi there! Welcome to the Salt Community! Thank you for making your first contribution. We have a lengthy process for issues and PRs. Someone from the Core Team will follow up as soon as possible. In the meantime, here’s some information that may help as you continue your Salt journey.
There are lots of ways to get involved in our community. Every month, there are around a dozen opportunities to meet with other contributors and the Salt Core team and collaborate in real time. The best way to keep track is by subscribing to the Salt Community Events Calendar. |
|
Hi @hzwns520. Are you able to rebase this on master and change the target branch to Also, would you mind adding a changelog and a test or two? |
|
Hi @hzwns520, any updates on rebasing to the master branch? |
|
yes, only update terraform.py
…------------------ 原始邮件 ------------------
发件人: "saltstack/salt" ***@***.***>;
发送时间: 2022年1月20日(星期四) 上午6:23
***@***.***>;
***@***.******@***.***>;
主题: Re: [saltstack/salt] update fix bug 60915 parse terraform.tfstate error (PR #61311)
Hi @hzwns520, any updates on rebasing to the master branch?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
MKLeb
added
the
Needs-Testcase
|
@hzwns520 I have ported this over to master. Would you mind writing a few tests for this? |
|
hi @hzwns520 , any chance you could write a test or two here? |
|
Congratulations on your first PR being merged! 🎉 |
What does this PR do?
After terraform v0.12.0, terraform parsed terraform.tfstate incorrectly, so added a new version of terraform.tfstate parse. No problem testing locally
What issues does this PR fix or reference?
Fixes:
#60915
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
No