Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#61650] Strip spaces from ssh config parameters #61652

Conversation

0x416e746f6e
Copy link
Contributor

What does this PR do?

What issues does this PR fix or reference?

Fixes: #61650

Previous Behavior

Previously it would pass the parameters from ssh config file as-is, with spaces/tabs in front of them.

New Behavior

The values of parameters are now stripped.

Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

Commits signed with GPG?

No

@0x416e746f6e 0x416e746f6e requested a review from a team as a code owner February 16, 2022 08:18
@0x416e746f6e 0x416e746f6e requested review from garethgreenaway and removed request for a team February 16, 2022 08:18
@welcome
Copy link

welcome bot commented Feb 16, 2022

Hi there! Welcome to the Salt Community! Thank you for making your first contribution. We have a lengthy process for issues and PRs. Someone from the Core Team will follow up as soon as possible. In the meantime, here’s some information that may help as you continue your Salt journey.
Please be sure to review our Code of Conduct. Also, check out some of our community resources including:

There are lots of ways to get involved in our community. Every month, there are around a dozen opportunities to meet with other contributors and the Salt Core team and collaborate in real time. The best way to keep track is by subscribing to the Salt Community Events Calendar.
If you have additional questions, email us at [email protected]. We’re glad you’ve joined our community and look forward to doing awesome things with you!

@garethgreenaway
Copy link
Contributor

@0x416e746f6e Thanks for the PR, can you please add a file under the changelog directory with a short description of the fix. Thanks!

Ch3LL
Ch3LL previously approved these changes Oct 6, 2022
Copy link
Contributor

@Ch3LL Ch3LL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good with this change other than the changelog that @garethgreenaway requested.

@Ch3LL
Copy link
Contributor

Ch3LL commented Oct 6, 2022

Since it was a small change, I went ahead and added a changelog file and migrated the test to the pytest directory.

@garethgreenaway would you mind re-reviewing?

@Ch3LL Ch3LL added Sulfur v3006.0 release code name and version and removed needs-changelog-file labels Oct 6, 2022
@garethgreenaway garethgreenaway merged commit 764f182 into saltstack:master Oct 6, 2022
@welcome
Copy link

welcome bot commented Oct 6, 2022

Congratulations on your first PR being merged! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Sulfur v3006.0 release code name and version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] salt-ssh fails with error command-line line 0: Missing argument
3 participants