Improve error handling and diagnostics in the proxmox salt-cloud driver #62212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
re-run full pr-centosstream-9-x86_64-py3-pytest |
pjcreath
force-pushed
the
proxmox-error-handling
branch
2 times, most recently
from
d3e27da
to
84cbc33
Compare
|
@Ch3LL it looks like this got auto-assigned to a reviewer who's away? Is there some way that I can get another randomly-assigned reviewer without pestering you? |
|
@s0undt3ch, this PR is also still in limbo. |
|
I've found another bug in the proxmox salt-cloud driver. Should I create new a PR based on master or should I add a commit to this PR? |
…oxmox salt-cloud driver
pjcreath
force-pushed
the
proxmox-error-handling
branch
from
84cbc33
to
2b5c117
Compare
|
Closed, superseded by #62559. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Raises an exception on authentication errors and logs full error details returned by the Proxmox server during VM creation.
What issues does this PR fix or reference?
Fixes: #62211
Previous Behavior
Error messages that prevent effective troubleshooting
New Behavior
Merge requirements satisfied?
Commits signed with GPG?
Yes