Fix order specific mount.mounted options for persist #62557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
|
re-run pr-amazon-2-x86_64-py3-pytest |
2 similar comments
|
re-run pr-amazon-2-x86_64-py3-pytest |
|
re-run pr-amazon-2-x86_64-py3-pytest |
|
re-run pr-amazon-2-x86_64-py3-pytest |
Ch3LL
suggested changes
Sep 7, 2022
Ch3LL
approved these changes
Sep 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR implements similar functionality to what was proposed by @thusoy in #57506, and does not restrict mount option comparisons to the same order.
What issues does this PR fix or reference?
Fixes: #62556
Previous Behavior
See issue for details.
New Behavior
Mount options are compared irrespective of order in the file and state block. This allows for comparison of functionality instead of literal string matching.
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes
Please review Salt's Contributing Guide for best practices.
See GitHub's page on GPG signing for more information about signing commits with GPG.