Add warning to syndic about eauth/publisher_acl #62746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Didn't get docs to build/preview locally - will need to double check Jenkins output to make sure that the actual link looks correct |
Ch3LL
previously approved these changes
Sep 26, 2022
|
@Ch3LL downloaded the built HTML docs from https://github.com/saltstack/salt/actions/runs/3115997991 and checked out topology/syndic.html and verified that the warning appears as expected, as well as both of the links work correctly 👍 |
garethgreenaway
approved these changes
Sep 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add docs, making it explicit that eauth/publisher_acl is not expected to work with Syndic (yet), also links to #62618, which will be used to track the actual fix.
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes