Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to mongo module, adding tests #62832

Merged
merged 6 commits into from
Oct 18, 2022

Conversation

garethgreenaway
Copy link
Contributor

@garethgreenaway garethgreenaway commented Oct 6, 2022

What does this PR do?

Updating various mongodb functions to sync up with latest version ofPymongo. Adding some unit tests for mongodb module.

What issues does this PR fix or reference?

Fixes: #62900

Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

Commits signed with GPG?

Yes

Please review Salt's Contributing Guide for best practices.

See GitHub's page on GPG signing for more information about signing commits with GPG.

…Pymongo. Adding some unit tests for mongodb module.
@garethgreenaway garethgreenaway requested a review from a team as a code owner October 6, 2022 20:49
@garethgreenaway garethgreenaway requested review from twangboy and removed request for a team October 6, 2022 20:49
@garethgreenaway garethgreenaway changed the title [WIP] Updates to mongo module, adding tests Updates to mongo module, adding tests Oct 12, 2022
Copy link
Contributor

@Ch3LL Ch3LL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this also requires a changelog

salt/modules/mongodb.py Outdated Show resolved Hide resolved
salt/modules/mongodb.py Outdated Show resolved Hide resolved
salt/modules/mongodb.py Outdated Show resolved Hide resolved
salt/modules/mongodb.py Show resolved Hide resolved
salt/modules/mongodb.py Show resolved Hide resolved
salt/modules/mongodb.py Show resolved Hide resolved
@Ch3LL Ch3LL added the Sulfur v3006.0 release code name and version label Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Sulfur v3006.0 release code name and version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] MongoDB module not up to date with latest pymongo library
2 participants