Use .select() for entrypoints under importlib_metadata>=5.0.0
#62854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whytewolf
previously approved these changes
Oct 10, 2022
s0undt3ch
suggested changes
Oct 11, 2022
s0undt3ch
approved these changes
Oct 11, 2022
|
@MKLeb @s0undt3ch Are there plans to merge this change to previous versions as well? |
|
@akshaypurohit I would say it is unlikley, as the previous major versions are all past Phase 2 support and have entered the CVE only phase. (https://docs.saltproject.io/salt/install-guide/en/latest/topics/salt-version-support-lifecycle.html) |
Closed
9 tasks
3 tasks
gentoo-bot
pushed a commit
to gentoo/gentoo
that referenced
this pull request
Jan 30, 2023
…1 hosts The Python 3.11 issue upstream: - saltstack/salt#62676 - saltstack/salt#62677 The importlib-metadata issue: - saltstack/salt#62851 - saltstack/salt#62854 Patches have been extracted from pull requests as following: - git clone https://github.com/saltstack/salt - cd salt - git diff b676e6338a7c094cb3335d11f851ac0e12222017^ 45b924bad865a00116d2e045fe71229f2dc3376e -- salt/utils/entrypoints.py > salt-3005.1-importlib-metadata-5-r1.patch - git diff 00352ae6e0ed0b80a75ec65cb925dd31a625010d^ 91efaea4975f37de97a88687d40e54e774151a8b -- salt/modules/file.py | head -n 123 > salt-3005.1-modules-file-python-3.11-host.patch Be sure to call salt-ssh with "--regen-thin" the first time after updating, to not end up running unpatched 3005.1(-r0) code. Closes: https://bugs.gentoo.org/875389 Closes: https://bugs.gentoo.org/883671 Signed-off-by: Sebastian Pipping <[email protected]>
freijon
pushed a commit
to freijon/gentoo
that referenced
this pull request
Jan 31, 2023
…1 hosts The Python 3.11 issue upstream: - saltstack/salt#62676 - saltstack/salt#62677 The importlib-metadata issue: - saltstack/salt#62851 - saltstack/salt#62854 Patches have been extracted from pull requests as following: - git clone https://github.com/saltstack/salt - cd salt - git diff b676e6338a7c094cb3335d11f851ac0e12222017^ 45b924bad865a00116d2e045fe71229f2dc3376e -- salt/utils/entrypoints.py > salt-3005.1-importlib-metadata-5-r1.patch - git diff 00352ae6e0ed0b80a75ec65cb925dd31a625010d^ 91efaea4975f37de97a88687d40e54e774151a8b -- salt/modules/file.py | head -n 123 > salt-3005.1-modules-file-python-3.11-host.patch Be sure to call salt-ssh with "--regen-thin" the first time after updating, to not end up running unpatched 3005.1(-r0) code. Closes: https://bugs.gentoo.org/875389 Closes: https://bugs.gentoo.org/883671 Signed-off-by: Sebastian Pipping <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
importlib_metadata>=5.0.0 deprecates the dict structure of the entrypoints object, so we use
.select()instead for iterating over them if needed.Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes