Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

influxdb_continuous_query: [fix] client connection #63007

Merged
merged 3 commits into from
Nov 9, 2022

Conversation

skob
Copy link
Contributor

@skob skob commented Nov 3, 2022

What does this PR do?

state influxdb_continuous_query was broken if influxdb_host param passed throw state

Commits signed with GPG?

No

@skob skob requested a review from a team as a code owner November 3, 2022 14:53
@skob skob requested review from dwoz and removed request for a team November 3, 2022 14:53
Copy link
Contributor

@Ch3LL Ch3LL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will require a changelog. If you could open an issue with the error that you were running into that will help me understand the reasoning for this change.

I'll ask the team to see if we are going to require test coverage here or not. thanks

@skob
Copy link
Contributor Author

skob commented Nov 8, 2022

related issue #59766

@Ch3LL
Copy link
Contributor

Ch3LL commented Nov 8, 2022

Thanks, can you add a changelog.

@waynew stated he is willing to investigate writing a test for this one.

@waynew
Copy link
Contributor

waynew commented Nov 8, 2022

@Ch3LL tests have been written and I went ahead and added a changelog while I was at it 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants