-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Syndics honor MoM acl #63428
Merged
Merged
Syndics honor MoM acl #63428
Commits on Jan 11, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 98a2655 - Browse repository at this point
Copy the full SHA 98a2655View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8296d5c - Browse repository at this point
Copy the full SHA 8296d5cView commit details -
We want to ensure that targeting invalid minions does *not* allow us to run any sort of shenanigans on the minions in question! This ensures that valid commands (i.e. file.touch in this case) cannot inadvertently be sent to minions that we don't have ACL for.
Configuration menu - View commit details
-
Copy full SHA for 93dd8b4 - Browse repository at this point
Copy the full SHA 93dd8b4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 20edbfd - Browse repository at this point
Copy the full SHA 20edbfdView commit details -
4
Configuration menu - View commit details
-
Copy full SHA for 5249eac - Browse repository at this point
Copy the full SHA 5249eacView commit details -
Configuration menu - View commit details
-
Copy full SHA for cb88480 - Browse repository at this point
Copy the full SHA cb88480View commit details -
Configuration menu - View commit details
-
Copy full SHA for da5ad94 - Browse repository at this point
Copy the full SHA da5ad94View commit details -
Configuration menu - View commit details
-
Copy full SHA for 26f7a4c - Browse repository at this point
Copy the full SHA 26f7a4cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 957d270 - Browse repository at this point
Copy the full SHA 957d270View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4a141d5 - Browse repository at this point
Copy the full SHA 4a141d5View commit details -
Configuration menu - View commit details
-
Copy full SHA for f6d1c78 - Browse repository at this point
Copy the full SHA f6d1c78View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9d0ba70 - Browse repository at this point
Copy the full SHA 9d0ba70View commit details -
It's possible that the output of ls is different for some reason, but test -f should always return 0 if the file exists, or 1 otherwise. We want it to be not 0.
Configuration menu - View commit details
-
Copy full SHA for 416a59c - Browse repository at this point
Copy the full SHA 416a59cView commit details
Commits on Jan 12, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 9cfdf3c - Browse repository at this point
Copy the full SHA 9cfdf3cView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.