[3006.x] Populate user data / name within runners and for runner events on the event bus #64038
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
3 tasks
3 tasks
whytewolf
previously approved these changes
Apr 6, 2023
|
Well this worked with classic 3005.1 hand-modified and with master branch, but not 3006.x, investigating why |
you forgot the saltmod fix in this one. |
|
@whytewolf tried that locally and failed. and doesn't explain why it worked on master branch with existing changes. |
dmurphy18
force-pushed
the
dt_fix_63148_3006x
branch
from
963b46a
to
366901c
Compare
added 3 commits
April 10, 2023 11:49
dmurphy18
force-pushed
the
dt_fix_63148_3006x
branch
from
366901c
to
7a84008
Compare
garethgreenaway
approved these changes
Apr 11, 2023
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Populates the user correctly through out runners and reported as such on the events on the event bus.
First noticed in orchestration runners in #63148 found this problem runs much deeper. saltutil.runner when called from the salt cli will properly propagate the user, as will the runner orchestrate.
Re-working of PR #64030 but specifically against 3006.x branch for a cleaner PR.
What issues does this PR fix or reference?
Fixes: #63148
Previous Behavior
The user responsible for the runner was reported as 'UNKNOWN' in the events on the event bus.
New Behavior
The user responsible for the runner is now correctly reported in the events on the event bus.
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes
Please review Salt's Contributing Guide for best practices.
See GitHub's page on GPG signing for more information about signing commits with GPG.