Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[master] Upgrade tornado to 6.1 #64304

Merged
merged 34 commits into from
May 23, 2023
Merged

[master] Upgrade tornado to 6.1 #64304

merged 34 commits into from
May 23, 2023

Conversation

dwoz
Copy link
Contributor

@dwoz dwoz commented May 18, 2023 •
edited
Loading

What does this PR do?

Upgrade our tornado to 6.1.

Why not 6.2? We'll get up to 6.2 in a follow up PR where we need to remove IOLoop.make_current and IOLoop.clear_current calls. In addition to upgrading some pkg dependencies which only support 6.1 for now. Regardless, this is a huge step in the right direction.

#64305

Related Issues:
#54759
#62960

Pre-cursor for:
#61380

What issues does this PR fix or reference?

Fixes:

Previous Behavior

Remove this section if not relevant

New Behavior

Remove this section if not relevant

Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

@dwoz dwoz requested review from a team and s0undt3ch as code owners May 18, 2023 21:01
@salt-project-bot-prod-environment salt-project-bot-prod-environment bot changed the title Upgrade tornado (for real this time) [master] Upgrade tornado (for real this time) May 18, 2023
@dwoz
Copy link
Contributor Author

dwoz commented May 18, 2023

We can verify tests for this by looking at the branch https://github.com/saltstack/salt/tree/tornado

@dwoz dwoz temporarily deployed to ci May 18, 2023 21:12 — with GitHub Actions Inactive
@dwoz dwoz temporarily deployed to ci May 18, 2023 21:12 — with GitHub Actions Inactive
@dwoz dwoz temporarily deployed to ci May 18, 2023 21:12 — with GitHub Actions Inactive
s0undt3ch
s0undt3ch suggested changes May 18, 2023
View reviewed changes
salt/netapi/rest_tornado/saltnado_websockets.py Outdated Show resolved Hide resolved
salt/transport/tcp.py Show resolved Hide resolved
salt/transport/tcp.py Outdated Show resolved Hide resolved
salt/version.py Outdated Show resolved Hide resolved
tests/pytests/unit/test_ext_importers.py Outdated Show resolved Hide resolved
@dwoz dwoz temporarily deployed to ci May 18, 2023 22:16 — with GitHub Actions Inactive
@dwoz dwoz force-pushed the tornado branch 3 times, most recently from 7cd5774 to 0884e9a Compare May 18, 2023 22:55
@dwoz dwoz temporarily deployed to ci May 18, 2023 23:09 — with GitHub Actions Inactive
@dwoz dwoz temporarily deployed to ci May 18, 2023 23:09 — with GitHub Actions Inactive
@dwoz dwoz temporarily deployed to ci May 18, 2023 23:09 — with GitHub Actions Inactive
@dwoz dwoz temporarily deployed to ci May 19, 2023 01:19 — with GitHub Actions Inactive
@dwoz dwoz temporarily deployed to ci May 19, 2023 01:19 — with GitHub Actions Inactive
@dwoz dwoz temporarily deployed to ci May 19, 2023 01:19 — with GitHub Actions Inactive
@dwoz dwoz temporarily deployed to ci May 19, 2023 02:21 — with GitHub Actions Inactive
@dwoz dwoz temporarily deployed to ci May 19, 2023 02:21 — with GitHub Actions Inactive
@dwoz dwoz temporarily deployed to ci May 19, 2023 02:21 — with GitHub Actions Inactive
@dwoz dwoz temporarily deployed to ci May 19, 2023 03:26 — with GitHub Actions Inactive
@dwoz dwoz temporarily deployed to ci May 19, 2023 03:26 — with GitHub Actions Inactive
@dwoz dwoz temporarily deployed to ci May 19, 2023 03:26 — with GitHub Actions Inactive
s0undt3ch
s0undt3ch suggested changes May 19, 2023
View reviewed changes
Copy link
Collaborator

@s0undt3ch s0undt3ch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Full review done this time.

doc/topics/releases/index.rst Outdated Show resolved Hide resolved
salt/metaproxy/deltaproxy.py Outdated Show resolved Hide resolved
salt/metaproxy/deltaproxy.py Outdated Show resolved Hide resolved
salt/metaproxy/proxy.py Outdated Show resolved Hide resolved
@s0undt3ch s0undt3ch temporarily deployed to ci May 23, 2023 12:08 — with GitHub Actions Inactive
@s0undt3ch s0undt3ch temporarily deployed to ci May 23, 2023 12:08 — with GitHub Actions Inactive
@s0undt3ch s0undt3ch temporarily deployed to ci May 23, 2023 12:08 — with GitHub Actions Inactive
@s0undt3ch s0undt3ch temporarily deployed to ci May 23, 2023 17:39 — with GitHub Actions Inactive
@s0undt3ch s0undt3ch temporarily deployed to ci May 23, 2023 17:39 — with GitHub Actions Inactive
@s0undt3ch s0undt3ch temporarily deployed to ci May 23, 2023 17:39 — with GitHub Actions Inactive
@s0undt3ch s0undt3ch temporarily deployed to ci May 23, 2023 17:49 — with GitHub Actions Inactive
@s0undt3ch s0undt3ch temporarily deployed to ci May 23, 2023 17:49 — with GitHub Actions Inactive
@s0undt3ch s0undt3ch temporarily deployed to ci May 23, 2023 17:49 — with GitHub Actions Inactive
@s0undt3ch s0undt3ch temporarily deployed to ci May 23, 2023 18:01 — with GitHub Actions Inactive
@s0undt3ch s0undt3ch temporarily deployed to ci May 23, 2023 18:01 — with GitHub Actions Inactive
@s0undt3ch s0undt3ch temporarily deployed to ci May 23, 2023 18:01 — with GitHub Actions Inactive
@s0undt3ch s0undt3ch temporarily deployed to ci May 23, 2023 18:13 — with GitHub Actions Inactive
@s0undt3ch s0undt3ch temporarily deployed to ci May 23, 2023 18:13 — with GitHub Actions Inactive
@s0undt3ch s0undt3ch temporarily deployed to ci May 23, 2023 18:13 — with GitHub Actions Inactive
@s0undt3ch s0undt3ch temporarily deployed to ci May 23, 2023 18:24 — with GitHub Actions Inactive
@s0undt3ch s0undt3ch temporarily deployed to ci May 23, 2023 18:24 — with GitHub Actions Inactive
@s0undt3ch s0undt3ch temporarily deployed to ci May 23, 2023 18:24 — with GitHub Actions Inactive
@s0undt3ch s0undt3ch temporarily deployed to ci May 23, 2023 18:45 — with GitHub Actions Inactive
@s0undt3ch s0undt3ch temporarily deployed to ci May 23, 2023 18:45 — with GitHub Actions Inactive
@s0undt3ch s0undt3ch temporarily deployed to ci May 23, 2023 18:45 — with GitHub Actions Inactive
@dwoz dwoz changed the title [master] Upgrade tornado (for real this time) [master] Upgrade tornado to 6.1 May 23, 2023
@dwoz dwoz requested a review from twangboy May 23, 2023 21:37
@garethgreenaway garethgreenaway merged commit 23582dc into master May 23, 2023
@garethgreenaway garethgreenaway deleted the tornado branch May 23, 2023 21:41
@hartwork hartwork mentioned this pull request Dec 4, 2023
Open
9 tasks
@krombel krombel mentioned this pull request Apr 9, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@s0undt3ch s0undt3ch s0undt3ch approved these changes

@whytewolf whytewolf whytewolf approved these changes

@twangboy twangboy twangboy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dwoz @s0undt3ch @whytewolf @twangboy @garethgreenaway