[master] Fix detection of Salt codename by "salt_version" execution module.

[meaksh]

What does this PR do?

This PR fixes an issue and some kind of mess we have around Salt version detection and codename resolution.

Currently, the codename resolution (salt_version.get_release_number and salt_version.equal) seems broken in Salt:

# pip3 install salt
Collecting salt
  Downloading salt-3006.1.tar.gz (20.4 MB)
[...]
Successfully installed Jinja2-3.0.3 MarkupSafe-2.0.1 PyYAML-6.0 certifi-2023.5.7 charset-normalizer-2.0.12 contextvars-2.4 distro-1.8.0 idna-3.4 immutables-0.19 jmespath-0.10.0 looseversion-1.2.0 msgpack-1.0.5 psutil-5.9.5 pycryptodomex-3.18.0 pyzmq-25.0.2 requests-2.27.1 salt-3006.1 typing-extensions-4.1.1 urllib3-1.26.16

# salt-call --version
salt-call 3006.1

# salt-call --local grains.get saltversion
local:
    3006.1

# salt-call --local salt_version.equal Sulfur
local:
    False

# salt-call --local salt_version.get_release_number Sulfur
local:
    No version assigned.

Previous Behavior

As mentioned above, the salt_version.get_release_number and salt_version.equal execution module functions (and probably others) are not working fine.

Other codenames seems working fine:

# salt-call --local salt_version.get_release_number Neon
local:
    3000

After some debugging, I've noticed the following situations:

• Codename definitions for Salt >= 3006 seems wrong at salt/version.py, as they map the version codename to the 300X.0 release but not to the entire 300X. This causes problems on codename detection.
• There seems to be a mess with the usage of can_have_dot_zero function that causes wrong a detection of Salt versions.

New Behavior

Salt version resolution works fine now and versions are detected as expected:

# salt-call --local salt_version.get_release_number Sulfur
local:
    3006

# salt-call --local salt_version.equal Sulfur
local:
    True

Merge requirements satisfied?

• Changelog - https://docs.saltproject.io/en/master/topics/development/changelog.html
• Tests written/updated

Commits signed with GPG?

Yes

Please review Salt's Contributing Guide for best practices.

See GitHub's page on GPG signing for more information about signing commits with GPG.

[meaksh]

This PR still need some changes. I set [WIP] tag and will update it soon.

[s0undt3ch]

💚 All backports created successfully

Status	Branch	Result
✅	3006.x

Questions ?

Please refer to the Backport tool documentation

[s0undt3ch]

💚 All backports created successfully

Status	Branch	Result
✅	3006.x

Questions ?

Please refer to the Backport tool documentation

[s0undt3ch]

💚 All backports created successfully

Status	Branch	Result
✅	3006.x

Questions ?

Please refer to the Backport tool documentation

[s0undt3ch]

💚 All backports created successfully

Status	Branch	Result
✅	3006.x

Questions ?

Please refer to the Backport tool documentation

[s0undt3ch]

💚 All backports created successfully

Status	Branch	Result
✅	3006.x

Questions ?

Please refer to the Backport tool documentation

[s0undt3ch]

💚 All backports created successfully

Status	Branch	Result
✅	3006.x

Questions ?

Please refer to the Backport tool documentation

[s0undt3ch]

💚 All backports created successfully

Status	Branch	Result
✅	3006.x

Questions ?

Please refer to the Backport tool documentation

[s0undt3ch]

💚 All backports created successfully

Status	Branch	Result
✅	3006.x

Questions ?

Please refer to the Backport tool documentation

[s0undt3ch]

💚 All backports created successfully

Status	Branch	Result
✅	3006.x

Questions ?

Please refer to the Backport tool documentation

[s0undt3ch]

💚 All backports created successfully

Status	Branch	Result
✅	3006.x

Questions ?

Please refer to the Backport tool documentation