Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3006.x] Fix pkg.install when using a port in the url. #64945

Merged
merged 3 commits into from
Aug 16, 2023

Conversation

Ch3LL
Copy link
Contributor

@Ch3LL Ch3LL commented Aug 9, 2023

What does this PR do?

Removes : from url when creating the cache directory to save the file. apt does not handle : in directory names and windows does not allow it.

What issues does this PR fix or reference?

Fixes: #64516

Previous Behavior

Could not install a package with a source url with an port in it.

New Behavior

Can now install a package with a source with a url and a port in it.

@Ch3LL Ch3LL requested a review from a team as a code owner August 9, 2023 14:37
@Ch3LL Ch3LL requested review from dwoz and removed request for a team August 9, 2023 14:37
@welcome
Copy link

welcome bot commented Aug 9, 2023

Hi there! Welcome to the Salt Community! Thank you for making your first contribution. We have a lengthy process for issues and PRs. Someone from the Core Team will follow up as soon as possible. In the meantime, here’s some information that may help as you continue your Salt journey.
Please be sure to review our Code of Conduct. Also, check out some of our community resources including:

There are lots of ways to get involved in our community. Every month, there are around a dozen opportunities to meet with other contributors and the Salt Core team and collaborate in real time. The best way to keep track is by subscribing to the Salt Community Events Calendar.
If you have additional questions, email us at [email protected]. We’re glad you’ve joined our community and look forward to doing awesome things with you!

@salt-project-bot-prod-environment salt-project-bot-prod-environment bot changed the title Fix pkg.install when using a port in the url. [3006.x] Fix pkg.install when using a port in the url. Aug 9, 2023
@Ch3LL Ch3LL temporarily deployed to ci August 9, 2023 14:53 — with GitHub Actions Inactive
@Ch3LL Ch3LL temporarily deployed to ci August 9, 2023 14:53 — with GitHub Actions Inactive
@Ch3LL Ch3LL temporarily deployed to ci August 9, 2023 14:54 — with GitHub Actions Inactive
@Ch3LL Ch3LL temporarily deployed to ci August 9, 2023 14:55 — with GitHub Actions Inactive
@Ch3LL Ch3LL temporarily deployed to ci August 9, 2023 15:08 — with GitHub Actions Inactive
@Ch3LL Ch3LL temporarily deployed to ci August 9, 2023 15:11 — with GitHub Actions Inactive
@Ch3LL Ch3LL temporarily deployed to ci August 9, 2023 16:01 — with GitHub Actions Inactive
@Ch3LL Ch3LL temporarily deployed to ci August 9, 2023 16:01 — with GitHub Actions Inactive
@Ch3LL Ch3LL temporarily deployed to ci August 9, 2023 16:01 — with GitHub Actions Inactive
@Ch3LL Ch3LL temporarily deployed to ci August 9, 2023 16:01 — with GitHub Actions Inactive
@Ch3LL Ch3LL temporarily deployed to ci August 9, 2023 16:02 — with GitHub Actions Inactive
@Ch3LL Ch3LL temporarily deployed to ci August 9, 2023 16:02 — with GitHub Actions Inactive
@Ch3LL Ch3LL temporarily deployed to ci August 9, 2023 16:28 — with GitHub Actions Inactive
@Ch3LL Ch3LL temporarily deployed to ci August 9, 2023 16:28 — with GitHub Actions Inactive
@Ch3LL Ch3LL temporarily deployed to ci August 9, 2023 16:28 — with GitHub Actions Inactive
@Ch3LL Ch3LL temporarily deployed to ci August 9, 2023 16:28 — with GitHub Actions Inactive
@Ch3LL Ch3LL temporarily deployed to ci August 9, 2023 16:28 — with GitHub Actions Inactive
@Ch3LL Ch3LL temporarily deployed to ci August 9, 2023 16:28 — with GitHub Actions Inactive
@Ch3LL Ch3LL temporarily deployed to ci August 14, 2023 18:22 — with GitHub Actions Inactive
@Ch3LL Ch3LL temporarily deployed to ci August 14, 2023 18:22 — with GitHub Actions Inactive
@Ch3LL Ch3LL temporarily deployed to ci August 14, 2023 18:22 — with GitHub Actions Inactive
@Ch3LL Ch3LL temporarily deployed to ci August 14, 2023 18:37 — with GitHub Actions Inactive
@Ch3LL Ch3LL temporarily deployed to ci August 14, 2023 18:40 — with GitHub Actions Inactive
@Ch3LL Ch3LL temporarily deployed to ci August 16, 2023 00:37 — with GitHub Actions Inactive
@Ch3LL Ch3LL temporarily deployed to ci August 16, 2023 00:38 — with GitHub Actions Inactive
@Ch3LL Ch3LL temporarily deployed to ci August 16, 2023 00:38 — with GitHub Actions Inactive
@Ch3LL Ch3LL temporarily deployed to ci August 16, 2023 01:14 — with GitHub Actions Inactive
@Ch3LL Ch3LL temporarily deployed to ci August 16, 2023 01:14 — with GitHub Actions Inactive
@Ch3LL Ch3LL temporarily deployed to ci August 16, 2023 01:14 — with GitHub Actions Inactive
@Ch3LL Ch3LL temporarily deployed to ci August 16, 2023 01:14 — with GitHub Actions Inactive
@Ch3LL Ch3LL temporarily deployed to ci August 16, 2023 01:14 — with GitHub Actions Inactive
@Ch3LL Ch3LL temporarily deployed to ci August 16, 2023 01:14 — with GitHub Actions Inactive
@Ch3LL Ch3LL requested a review from s0undt3ch August 16, 2023 01:54
@s0undt3ch s0undt3ch temporarily deployed to ci August 16, 2023 09:03 — with GitHub Actions Inactive
@s0undt3ch s0undt3ch temporarily deployed to ci August 16, 2023 09:03 — with GitHub Actions Inactive
@s0undt3ch s0undt3ch temporarily deployed to ci August 16, 2023 09:04 — with GitHub Actions Inactive
@s0undt3ch s0undt3ch temporarily deployed to ci August 16, 2023 09:04 — with GitHub Actions Inactive
@s0undt3ch s0undt3ch temporarily deployed to ci August 16, 2023 09:17 — with GitHub Actions Inactive
@s0undt3ch s0undt3ch temporarily deployed to ci August 16, 2023 09:20 — with GitHub Actions Inactive
@s0undt3ch s0undt3ch temporarily deployed to ci August 16, 2023 10:07 — with GitHub Actions Inactive
@s0undt3ch s0undt3ch temporarily deployed to ci August 16, 2023 10:07 — with GitHub Actions Inactive
@s0undt3ch s0undt3ch temporarily deployed to ci August 16, 2023 10:07 — with GitHub Actions Inactive
@s0undt3ch s0undt3ch temporarily deployed to ci August 16, 2023 10:07 — with GitHub Actions Inactive
@s0undt3ch s0undt3ch temporarily deployed to ci August 16, 2023 10:07 — with GitHub Actions Inactive
@s0undt3ch s0undt3ch temporarily deployed to ci August 16, 2023 10:07 — with GitHub Actions Inactive
@Ch3LL Ch3LL merged commit 647b280 into saltstack:3006.x Aug 16, 2023
321 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants