Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3006.x] Ensure __kwarg__ is preserved when checking for kwargs #65180

Merged
merged 4 commits into from
Sep 14, 2023
Merged

[3006.x] Ensure __kwarg__ is preserved when checking for kwargs #65180

merged 4 commits into from
Sep 14, 2023

Conversation

garethgreenaway
Copy link
Contributor

@garethgreenaway garethgreenaway commented Sep 12, 2023 •
edited
Loading

What does this PR do?

Ensure kwarg is preserved when checking for kwargs

What issues does this PR fix or reference?

Fixes: #65179

Previous Behavior

Proxy minions missing kwargs

New Behavior

Ensure kwargs are sent to proxy minions correctly

Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

Commits signed with GPG?

Yes

Please review Salt's Contributing Guide for best practices.

See GitHub's page on GPG signing for more information about signing commits with GPG.

@garethgreenaway garethgreenaway requested a review from a team as a code owner September 12, 2023 21:55
@garethgreenaway garethgreenaway requested review from Ch3LL and removed request for a team September 12, 2023 21:55
@salt-project-bot-prod-environment salt-project-bot-prod-environment bot changed the title Ensure kwargs are sent along correctly to multiple sub proxies. [3006.x] Ensure kwargs are sent along correctly to multiple sub proxies. Sep 12, 2023
@garethgreenaway garethgreenaway added this to the Sulfur v3006.4 milestone Sep 12, 2023
@garethgreenaway garethgreenaway temporarily deployed to ci September 12, 2023 22:12 — with GitHub Actions Inactive
@garethgreenaway garethgreenaway temporarily deployed to ci September 12, 2023 22:12 — with GitHub Actions Inactive
@garethgreenaway garethgreenaway temporarily deployed to ci September 12, 2023 22:12 — with GitHub Actions Inactive
@garethgreenaway garethgreenaway temporarily deployed to ci September 12, 2023 22:14 — with GitHub Actions Inactive
@garethgreenaway garethgreenaway temporarily deployed to ci September 12, 2023 22:30 — with GitHub Actions Inactive
@garethgreenaway garethgreenaway temporarily deployed to ci September 12, 2023 22:32 — with GitHub Actions Inactive
@garethgreenaway garethgreenaway temporarily deployed to ci September 13, 2023 03:20 — with GitHub Actions Inactive
@garethgreenaway garethgreenaway temporarily deployed to ci September 13, 2023 03:20 — with GitHub Actions Inactive
@garethgreenaway garethgreenaway temporarily deployed to ci September 13, 2023 03:20 — with GitHub Actions Inactive
@garethgreenaway garethgreenaway temporarily deployed to ci September 13, 2023 03:20 — with GitHub Actions Inactive
@garethgreenaway garethgreenaway temporarily deployed to ci September 13, 2023 03:20 — with GitHub Actions Inactive
@garethgreenaway garethgreenaway temporarily deployed to ci September 13, 2023 03:20 — with GitHub Actions Inactive
@garethgreenaway garethgreenaway temporarily deployed to ci September 13, 2023 16:06 — with GitHub Actions Inactive
@garethgreenaway garethgreenaway temporarily deployed to ci September 13, 2023 16:06 — with GitHub Actions Inactive
@garethgreenaway garethgreenaway temporarily deployed to ci September 13, 2023 16:06 — with GitHub Actions Inactive
@garethgreenaway garethgreenaway temporarily deployed to ci September 13, 2023 16:06 — with GitHub Actions Inactive
@garethgreenaway garethgreenaway temporarily deployed to ci September 13, 2023 16:06 — with GitHub Actions Inactive
@garethgreenaway garethgreenaway temporarily deployed to ci September 13, 2023 16:06 — with GitHub Actions Inactive
@garethgreenaway garethgreenaway changed the title [3006.x] Ensure kwargs are sent along correctly to multiple sub proxies. [3006.x] Ensure __kwarg__ is preserved when checking for kwargs Sep 13, 2023
@Ch3LL Ch3LL temporarily deployed to ci September 13, 2023 20:14 — with GitHub Actions Inactive
@Ch3LL Ch3LL temporarily deployed to ci September 13, 2023 20:14 — with GitHub Actions Inactive
@Ch3LL Ch3LL temporarily deployed to ci September 13, 2023 20:14 — with GitHub Actions Inactive
@Ch3LL Ch3LL temporarily deployed to ci September 13, 2023 20:14 — with GitHub Actions Inactive
@Ch3LL Ch3LL temporarily deployed to ci September 13, 2023 20:32 — with GitHub Actions Inactive
@Ch3LL Ch3LL temporarily deployed to ci September 13, 2023 20:35 — with GitHub Actions Inactive
@garethgreenaway garethgreenaway mentioned this pull request Sep 13, 2023
Closed
@Ch3LL Ch3LL temporarily deployed to ci September 14, 2023 01:20 — with GitHub Actions Inactive
@Ch3LL Ch3LL temporarily deployed to ci September 14, 2023 01:20 — with GitHub Actions Inactive
@Ch3LL Ch3LL temporarily deployed to ci September 14, 2023 01:20 — with GitHub Actions Inactive
@Ch3LL Ch3LL temporarily deployed to ci September 14, 2023 01:20 — with GitHub Actions Inactive
@Ch3LL Ch3LL temporarily deployed to ci September 14, 2023 01:20 — with GitHub Actions Inactive
@Ch3LL Ch3LL temporarily deployed to ci September 14, 2023 01:20 — with GitHub Actions Inactive
@Ch3LL Ch3LL merged commit 7f5f3c8 into saltstack:3006.x Sep 14, 2023
359 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ch3LL Ch3LL Ch3LL approved these changes

Assignees
No one assigned
Labels
Sulfur v3006.4
Projects
None yet
Milestone
Sulfur v3006.4
Development

Successfully merging this pull request may close these issues.
2 participants
@garethgreenaway @Ch3LL