Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3006.x] Fix install of logrotate config for debian pkg #65318

Merged
merged 7 commits into from
Nov 3, 2023
Merged

[3006.x] Fix install of logrotate config for debian pkg #65318

merged 7 commits into from
Nov 3, 2023

Commits on Nov 2, 2023

  1. Fix install of logrotate config for debian pkg 

    Fixes the install of logrotate config for the debian pkg
by moving file to pkg/common/logrotate/salt-common. File
is installed via salt-common.install file, which can't
rename files, only copy them to a directory, so we need to
rename the file and put it in a subdir of pkg/common.

Adds /etc/logrotate.d/salt-common to salt.common.conffiles to
ensure that dpkg will not overwrite configs modified by users.

Also updates RPM spec file for new location of logrotate config.

Config needs to be /etc/logrotate.d/salt-common as that is what
is used by 3005.x packages.
    @barneysowood @s0undt3ch
    barneysowood authored and s0undt3ch committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    f3dfcd0 View commit details
    Browse the repository at this point in the history

  2. Add initial tests for logrotate configs 

    Adds initial tests for logrotate configs to ensure they are installed
in the correct location.
    @barneysowood @s0undt3ch
    barneysowood authored and s0undt3ch committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    f5827a0 View commit details
    Browse the repository at this point in the history

  3. Add test for issue 65231

    @barneysowood @s0undt3ch
    barneysowood authored and s0undt3ch committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    3b39532 View commit details
    Browse the repository at this point in the history

  4. Add changelog

    @barneysowood @s0undt3ch
    barneysowood authored and s0undt3ch committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    3fe1fba View commit details
    Browse the repository at this point in the history

  5. Disable test for 65231 on downgrade to 3006.3 

    Disables the running of the test for 65231 when downgrading to 3006.3
as the issue that is fixed is in 3006.3 so test will fail when 3006.3
is installed.
    @barneysowood @s0undt3ch
    barneysowood authored and s0undt3ch committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    ba84b72 View commit details
    Browse the repository at this point in the history

  6. Address my own review comments 

    Signed-off-by: Pedro Algarvio <[email protected]>
    @s0undt3ch
    s0undt3ch committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    d6dccc1 View commit details
    Browse the repository at this point in the history

  7. The problem is still present in 3006.4, can't test downgrade 

    Signed-off-by: Pedro Algarvio <[email protected]>
    @s0undt3ch
    s0undt3ch committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    6bff5cb View commit details
    Browse the repository at this point in the history