-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add codecov #107
add codecov #107
Conversation
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awesome, thanks for adding code coverage!
I was looking through code coverage report and sometimes it is annoying like abstract methods are labeled as not being tested, and some edge case error messages are not being tested, is there any way to avoid these being labeled as not covered?
Also some files I don't want to test, for example my custom shuffling implementation it is indeterministic so hard to test, can we ignore these files somehow ?
@@ -1,4 +1,5 @@ | |||
[![CircleCI](https://dl.circleci.com/status-badge/img/gh/sambanova/generative_data_prep/tree/main.svg?style=svg)](https://dl.circleci.com/status-badge/redirect/gh/sambanova/generative_data_prep/tree/main) | |||
[![codecov](https://codecov.io/gh/sambanova/generative_data_prep/graph/badge.svg?token=9CYRCUOOAO)](https://codecov.io/gh/sambanova/generative_data_prep) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That'll update once this merges to main since it shows the status of main
@snova-zoltanc I'm not sure if we can ignore that but I can look into it in the future. Also, I don't think its too difficult to cover them, we just need to parametrize one pytest with all these callbacks and see if the appropriate exceptions are raise. |
Sounds great, I may ask for some recommendations on this if we plan to increase code coverage in the future. |
@snova-zoltanc sounds good; for sure! always happy to help when I can |
Please refer to CONTRIBUTING.md for detailed instructions.
Summary
PR Checklist