Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow null value on enum properties. #40

Merged
merged 1 commit into from
Aug 20, 2024
Merged

Allow null value on enum properties. #40

merged 1 commit into from
Aug 20, 2024

Conversation

samchon
Copy link
Owner

@samchon samchon commented Aug 20, 2024

It is nonsensible to inserting null value to enum property array.

However, Github OpenAPI document is actually doing the crazy thing.

This PR supports it by allowing the null value to the enum proeprty array.

It is nonsensible to inserting `null` value to `enum` property array, but Github OpenAPI document is actually doing the crazy thing.

This PR supports it by allowing the `null` value to the `enum` proeprty array.
@samchon samchon added bug Something isn't working enhancement New feature or request labels Aug 20, 2024
@samchon samchon self-assigned this Aug 20, 2024
Copy link
Owner Author

@samchon samchon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test OK.

@samchon samchon merged commit a8414d1 into master Aug 20, 2024
4 checks passed
@samchon samchon deleted the feature/enum-null branch August 20, 2024 07:15
samchon added a commit to samchon/typia that referenced this pull request Aug 20, 2024
In the JSON schema definition, it is nonsensible to inserting null value to enum property array, but Github OpenAPI document is actually doing the crazy thing.

This PR supports it by allowing the null value to the enum proeprty array.
samchon added a commit to samchon/typia that referenced this pull request Aug 20, 2024
samchon added a commit to samchon/nestia that referenced this pull request Aug 20, 2024
In the JSON schema definition, it is nonsensible to inserting null value to enum property array.

However, Github OpenAPI document is actually doing the crazy thing.

This PR supports it by allowing the null value to the enum proeprty array.
samchon added a commit to samchon/nestia that referenced this pull request Aug 20, 2024
samchon added a commit to wrtnio/openai-function-schema that referenced this pull request Aug 20, 2024
In the JSON schema definition, it is nonsensible to inserting null value to enum property array.

However, Github OpenAPI document is actually doing the crazy thing.

This PR supports it by allowing the null value to the enum proeprty array.
samchon added a commit to wrtnio/openai-function-schema that referenced this pull request Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant