Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uniform error pattern. #85

Merged
merged 2 commits into from
Jun 25, 2024
Merged

Uniform error pattern. #85

merged 2 commits into from
Jun 25, 2024

Conversation

samchon
Copy link
Owner

@samchon samchon commented Jun 25, 2024

No more use tstl's Error extended custom error classes, but just utilize pure Error class. Also, normalized every error messages to start from the Error on Class.method(): message... prefix.

Also, AcceptorBase.inspectReady() had wrong conditional statement about closing event. This PR also fixes it.

No more use `tstl`'s `Error` extended custom error classes, but just utilize pure `Error` class. Also, normalized every error messages to start from the `Error on Class.method(): message...` prefix.

Also, `AcceptorBase.inspectReady()` had wrong conditional statement about closing event. This PR also fixes it.
@samchon samchon added bug Something isn't working enhancement New feature or request documentation Improvements or additions to documentation labels Jun 25, 2024
@samchon samchon self-assigned this Jun 25, 2024
Copy link

socket-security bot commented Jun 25, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@mui/[email protected] None +2 19 MB brijeshb42
npm/@mui/[email protected] environment +31 22 MB brijeshb42
npm/@rollup/[email protected] eval, network +1 5.61 MB lukastaegert
npm/@rollup/[email protected] eval, unsafe Transitive: environment +5 2.35 MB lukastaegert
npm/@rollup/[email protected] environment, filesystem +2 242 kB shellscape
npm/@types/[email protected] None +1 21.2 kB types
npm/@types/[email protected] None +1 2.04 MB types
npm/@types/[email protected] None 0 1.76 kB types
npm/@types/[email protected] None +2 1.69 MB types
npm/@typescript-eslint/[email protected] Transitive: environment, filesystem +23 6.84 MB jameshenry
npm/@typescript-eslint/[email protected] Transitive: environment, filesystem +11 2 MB jameshenry
npm/[email protected] filesystem, network, unsafe Transitive: environment, eval +95 4.87 MB goto-bus-stop
npm/[email protected] environment, filesystem Transitive: eval, unsafe +48 9.04 MB eslintbot
npm/[email protected] Transitive: environment, filesystem, network, shell, unsafe +34 864 kB 75lb
npm/[email protected] filesystem 0 10.3 kB superjoe
npm/[email protected] environment, filesystem, network, shell, unsafe +23 1.2 GB vercel-release-bot
npm/[email protected] environment 0 334 kB google-wombot
npm/[email protected] environment, filesystem Transitive: shell +35 3.63 MB isaacs
npm/[email protected] environment, filesystem 0 2.28 MB lukastaegert
npm/[email protected] environment, filesystem +2 402 kB nonara
npm/[email protected] Transitive: environment, filesystem +12 4.95 MB typedoc-bot
npm/[email protected] filesystem 0 142 kB danielpanpm
npm/[email protected] network 0 57.4 kB jakechampion
npm/[email protected] network 0 122 kB lpinca

🚮 Removed packages: npm/@mui/[email protected], npm/@mui/[email protected], npm/@rollup/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected]

View full report↗︎

Copy link

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert Package NoteSourceCI
Install scripts npm/[email protected] 🚫

View full report↗︎

Next steps

What is an install script?

Install scripts are run when the package is installed. The majority of malware in npm is hidden in install scripts.

Packages should not be running non-essential scripts during install and there are often solutions to problems people solve with install scripts that can be run at publish time instead.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/[email protected] or ignore all packages with @SocketSecurity ignore-all

@samchon samchon merged commit 1482c9c into master Jun 25, 2024
6 of 7 checks passed
@samchon samchon deleted the features/error branch June 25, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant