Fix createParamOrRef #336
Merged
Fix createParamOrRef #336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
@samchungy |
No problemo, I didn't catch it tbh. No need to do anything, there's also poor test coverage for it so that's more my fault. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This one slipped through unintentionally as a breaking change:
https://github.com/samchungy/zod-openapi/pull/330/files#diff-ddd2a05e83d80d4b6e2db78d84993a94c09f9c56b563abbb6e3de61b422f7f38R132
samchungy/fastify-zod-openapi#166
samchungy/fastify-zod-openapi#165
TODO: Some unit tests should have broken... Clearly missing something here and definitely due for a re-write especially with 3 optionals...