Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add redis auth support #1026

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

munnerz
Copy link

@munnerz munnerz commented Dec 20, 2016

This PR adds support for redis authentication through the REDIS_PASSWORD environment variable.

For a production-ready environment this is a requirement for us!

assets/runtime/functions Show resolved Hide resolved
assets/runtime/functions Show resolved Hide resolved
@guoyoujin
Copy link

@munnerz That's a good idea, that is what I need,Thank you

@stale
Copy link

stale bot commented May 6, 2020

This issue has been automatically marked as stale because it has not had any activity for the last 60 days. It will be closed if no further activity occurs during the next 7 days. Thank you for your contributions.

@stale stale bot added the wontfix label May 6, 2020
@solidnerd
Copy link
Collaborator

Hey @munnerz,
I know this pr is a bit older. I would like to merge this into master. Could you rebase your pr?

@stale stale bot removed the wontfix label May 10, 2020
gnuhub added a commit to gnuhub/docker-gitlab that referenced this pull request Jun 21, 2020
@mpv945
Copy link

mpv945 commented Jan 13, 2022

rake aborted!
URI::InvalidURIError: bad URI(is not URI?): "redis://{{REDIS_PASSWORD}}redis:6379/0"
/home/git/gitlab/lib/gitlab/redis/wrapper.rb:148:in redis_store_options' /home/git/gitlab/lib/gitlab/redis/wrapper.rb:120:in params'
/home/git/gitlab/lib/gitlab/redis/wrapper.rb:20:in params' /home/git/gitlab/lib/gitlab/redis/wrapper.rb:111:in redis'
/home/git/gitlab/lib/gitlab/redis/wrapper.rb:31:in `block in pool'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants