Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move sentry hubs and tx's to functions #100

Merged
merged 1 commit into from
Feb 8, 2024

Conversation

samgozman
Copy link
Owner

@samgozman samgozman commented Feb 8, 2024

Closes #79

Copy link

sonarcloud bot commented Feb 8, 2024

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

1 New issue
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

codecov bot commented Feb 8, 2024

Codecov Report

Attention: 103 lines in your changes are missing coverage. Please review.

Comparison is base (0ab8175) 37.61% compared to head (033ff54) 40.49%.

Files Patch % Lines
jobs/job.go 11.20% 103 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #100      +/-   ##
==========================================
+ Coverage   37.61%   40.49%   +2.88%     
==========================================
  Files          21       21              
  Lines        2018     1968      -50     
==========================================
+ Hits          759      797      +38     
+ Misses       1198     1113      -85     
+ Partials       61       58       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@samgozman samgozman merged commit 5d6ebc7 into main Feb 8, 2024
4 of 5 checks passed
@samgozman samgozman deleted the 79-refactor-jobs-transaction branch February 8, 2024 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor Jobs: pass transaction to the functions, move hubs & breadcrumbs to the functions
1 participant