Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't compose news that was flagged #92

Merged
merged 6 commits into from
Feb 1, 2024

Conversation

samgozman
Copy link
Owner

@samgozman samgozman commented Feb 1, 2024

Closes #91

Copy link

codecov bot commented Feb 1, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (fc7dea7) 38.43% compared to head (52fbbc8) 39.04%.

Files Patch % Lines
jobs/job.go 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #92      +/-   ##
==========================================
+ Coverage   38.43%   39.04%   +0.61%     
==========================================
  Files          21       21              
  Lines        2001     2018      +17     
==========================================
+ Hits          769      788      +19     
+ Misses       1173     1172       -1     
+ Partials       59       58       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Feb 1, 2024

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

5 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@samgozman samgozman marked this pull request as ready for review February 1, 2024 05:52
@samgozman samgozman merged commit 6d13b0b into main Feb 1, 2024
5 checks passed
@samgozman samgozman deleted the 91-dont-compose-news-that-was-flagged branch February 1, 2024 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't compose news that was flagged suspicious
1 participant