This repository has been archived by the owner on Jan 15, 2020. It is now read-only.
io.js 3 / node 4 / nan 2.1 support (DONE) #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Adding to the list: nodejs/node#2798. |
|
We're still not there, NAN 2.1 is not released yet. 👎 |
|
So, the good news is NAN 2.1 released, so finally this PR gets done. All test passed on all Node.js versions including 4.x. I've also updated Travis stuff to do tests on Mac and Linux on the whole version range. All tests passed there of course. @samshull please merge and release this as soon as you can, because there are many who waits for this module update. Thanks for your hard work there anyway! |
unbornchikken
changed the title
|
👍 |
|
👍 Great job! Thanks! |
samshull
pushed a commit
that referenced
this pull request
Oct 10, 2015
io.js 3 / node 4 / nan 2.1 support (DONE)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I'm opening up this PR, however it is not yet finished. Just for everyone to know that it is in progress.
Everything compiles except line https://github.com/unbornchikken/node-proxy/blob/master/src/node-proxy.cc#L1533. The issue is that nan 2 doesn't support SetCallAsFunctionHandler. I've opened up an issue: nodejs/nan#427
If anyone has hope for this gets merged, please +1 that nan issue above.