Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Possible bug with %U #56

Closed
ghost opened this issue Mar 26, 2015 · 4 comments · Fixed by #57
Closed

Possible bug with %U #56

ghost opened this issue Mar 26, 2015 · 4 comments · Fixed by #57

Comments

@ghost
Copy link

ghost commented Mar 26, 2015

This looks like a bug with %U:

console.log( strftime('%U', (new Date('03-25-2017 00:00:00'))) ) // 12
console.log( strftime('%U', (new Date('03-26-2017 00:00:00'))) ) // 13
console.log( strftime('%U', (new Date('03-27-2017 00:00:00'))) ) // 12
console.log( strftime('%U', (new Date('04-02-2017 00:00:00'))) ) // 13
@alexandrnikitin alexandrnikitin mentioned this issue Mar 26, 2015
Merged
samsonjs added a commit that referenced this issue Mar 26, 2015
@samsonjs
Merge pull request #57 from alexandrnikitin/Issue56_BugInWeekNumber
603a716 
Fixes #56 (Bug in %U)
samsonjs added a commit that referenced this issue Mar 26, 2015
@samsonjs
Revert "Fixes #56 (Bug in %U)"
ab3d4a0
samsonjs added a commit that referenced this issue Mar 26, 2015
@samsonjs
Merge pull request #58 from samsonjs/revert-57-Issue56_BugInWeekNumber
22ddd89 
Revert "Fixes #56 (Bug in %U)"
@ghost
Copy link
Author

ghost commented Mar 27, 2015

Should the issue be reopened, since the fix was reverted?

@samsonjs
Copy link
Owner

Yup, reopened.

@samsonjs samsonjs reopened this Mar 27, 2015
samsonjs added a commit that referenced this issue Mar 29, 2015
@samsonjs
Merge pull request #59 from samsonjs/Issue56_BugInWeekNumber
fe2892e 
Fixes #56 (Bug in %U)
@samsonjs
Copy link
Owner

samsonjs commented Apr 1, 2015

Ok, master is fixed and it will be rolled out in 0.9.1 shortly. We had a bug in the tests but it's sorted. Thanks for the report @clexit!

@ghost
Copy link
Author

ghost commented Apr 1, 2015

Thanks for the quick fix!

@snyk-bot snyk-bot mentioned this issue Mar 27, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes #56 (Bug in %U)
1 participant
@samsonjs