Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test case helper and fix EOF detection #1641

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Test case helper and fix EOF detection #1641

wants to merge 1 commit into from

Commits on Dec 2, 2022

  1. wip on #1614 

    This is more complicated than originally described because the file encoding isn't really described and java bytes include negative values.
EOF is triggered correctly, but it's also triggered on various potential characters which become negative values when they are truncated to byte.
It's unclear if this is meant to only read ASCII, ISO 8859-1, or UTF-8 but nothing outside of the ascii space works correctly.
    @lbergelson
    lbergelson committed Dec 2, 2022
    Configuration menu
    Copy the full SHA
    e5ba94c View commit details
    Browse the repository at this point in the history