Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for lowering completeness threshold on ffmpeg adapter #114

Merged
merged 1 commit into from
Nov 9, 2022

Conversation

cjcolvar
Copy link
Member

@cjcolvar cjcolvar commented Nov 8, 2022

In our production avalon instance we've had failed encoding jobs due to ffmpeg reporting a progress of 99% when it finishes encoding. The ffmpeg adapter currently uses the ceiling of percentage thus allowing a 1% drift but the files that failed are very short (<2 sec) so a very small variance in output time in comparison to input time can lead to a greater than 1% difference. This PR adds a class attribute on the ffmpeg adapter that allows implementers to lower the threshold if they choose.

Copy link
Contributor

@masaball masaball left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@cjcolvar cjcolvar merged commit adc4a7b into main Nov 9, 2022
@cjcolvar cjcolvar deleted the wiggle_room branch November 9, 2022 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants