Allow for lowering completeness threshold on ffmpeg adapter #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In our production avalon instance we've had failed encoding jobs due to ffmpeg reporting a progress of 99% when it finishes encoding. The ffmpeg adapter currently uses the ceiling of percentage thus allowing a 1% drift but the files that failed are very short (<2 sec) so a very small variance in output time in comparison to input time can lead to a greater than 1% difference. This PR adds a class attribute on the ffmpeg adapter that allows implementers to lower the threshold if they choose.