Convert TODO comments to issues

[botimer]

There are about 20 TODO comments throughout the code. These should be converted to issues and referenced, or pruned if the person reviewing can decide that they are no longer relevant.

[jrgriffiniii]

The following issues were created from these TODO comments:

• Handle order within ActiveFedora::Relation::Merger#merge #1329
• ActiveFedora::Associations::SingularAssociation#find_target should use Fedora (rather than Solr) to resolve singular relationships #1330
• ActiveFedora::WithMetadata#create_or_update should only update nodes if they have been changed #1331
• ActiveFedora::Associations::IndirectlyContainsAssociation should be restructured into two child classes #1332
• Should .method_defined? be invoked within ActiveFedora::Associations::Builder::CollectionAssociation.define_callback? #1333
• ActiveFedora::Indexing::Suffix.config field types should not be symbols #1334
• ActiveFedora::Associations::DirectlyContainsOneAssociation#find_target should not parse the RDF graph #1335
• Should ActiveFedora::Attributes::PropertyBuilder#build accept block arguments? #1336
• ActiveFedora::Aggregation::ListSource#persist_ordered_self must explicitly set RDF subjects for subgraphs #1337
• Should ActiveFedora::Indexing::FieldMapper#solr_name used the field_name, or just detect the type of input data to generate the name for Solr Fields? #1338
• ActiveFedora::Indexing::FieldMapper#solr_names_and_values should not use custom converters #1339
• ActiveFedora::Associations::CollectionAssociation#ids_writer should use a mutator method based upon the ActiveFedora::Base object it modified #1340
• ActiveFedora::Associations::CollectionAssociation#delete_all should find an alternative to loading each resource before deleting it #1341
• Object should be frozen after being deserialized from Solr in ActiveFedora::LoadableFromJson#init_with_json #1342
• Evaluate whether or not ActiveFedora::NestedAttributes#define_autosave_association_callbacks and other method generation behaves as expected #1343
• ActiveFedora::FinderMethods#field_name_for should not assume that stored_searchable is the Solr field type #1344
• Should ActiveFedora::Associations::IndirectlyContainsAssociation#container use the options Hash to retrieve the predicate for inserted_content_relation #1345
• Update the Solr schema to 1.6 #1346
• #collect_join_chain in ActiveFedora::Reflection classes should be deprecated in favor of #chain #1347

[botimer]

I think we should back through the source and link the issues above. I'm happy to do that. Thanks for working through all of them, @jrgriffiniii.

[botimer]

Okay, PR #1359 opened, which I think closes this one off. Happy for you to review, @jrgriffiniii.