Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

don't try to delegate ""system_create_dtsi" to #indexer #1460

Merged
merged 1 commit into from
Mar 9, 2022
Merged

don't try to delegate ""system_create_dtsi" to #indexer #1460

merged 1 commit into from
Mar 9, 2022

Conversation

no-reply
Copy link
Contributor

not all models have an indexer (e.g. ActiveFedora::File inheritors do
not). trying to query them with MyModel.all shouldn't raise a NameError.

@no-reply no-reply mentioned this pull request Dec 15, 2021
Merged
@jrgriffiniii
don't try to delegate ""system_create_dtsi" to #indexer
c6eb374 
not all models have an indexer (e.g. `ActiveFedora::File` inheritors do
not). trying to query them with `MyModel.all` shouldn't raise a `NameError`.
@jrgriffiniii jrgriffiniii merged commit 35a866f into main Mar 9, 2022
@jrgriffiniii jrgriffiniii deleted the issue-1459 branch March 9, 2022 14:54
tpendragon added a commit that referenced this pull request Jul 25, 2022
@tpendragon
Prepare for release 13.3.0
e2673d0 
Includes:

- #1483 (Rails 6.1 Support)
- #1480 (README Badges)
- #1462 (Handle RSolr Deprecation of read_timeout)
- #1460 (Don't delegate system_dtsi to #indexer)
- #1453 (Update README/CONTRIBUTING)
@tpendragon tpendragon mentioned this pull request Jul 25, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dunn dunn dunn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@no-reply @dunn @jrgriffiniii