Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

i162 - import valkyrie works with filesets #936

Merged
merged 36 commits into from
Mar 15, 2024
Merged

i162 - import valkyrie works with filesets #936

merged 36 commits into from
Mar 15, 2024

Commits on Mar 11, 2024

  1. Revert "WIP - try to import filesets with valkyrie resources" 

    This reverts commit 4ab31b6.
    @ShanaLMoore
    ShanaLMoore committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    71cec53 View commit details
    Browse the repository at this point in the history

  2. WIP

    @ShanaLMoore
    ShanaLMoore committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    ad06786 View commit details
    Browse the repository at this point in the history

  3. WIP - try to import filesets with valkyrie resources

    @ShanaLMoore
    ShanaLMoore committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    6c4490b View commit details
    Browse the repository at this point in the history

Commits on Mar 12, 2024

  1. 🚧 WIP: get filesets to import via bulkrax x valkyrie

    @ShanaLMoore
    ShanaLMoore committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    6f0c049 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'i161-import-collection-resources' into i162-import-valk… 

    …yrie-works-and-filesets
    @ShanaLMoore
    ShanaLMoore committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    d2cde2b View commit details
    Browse the repository at this point in the history

  3. 🎉 WIP: filesets to imports via bulkrax x valkyrie 

    There's still a lot to clean up here, but the import is successful in this commit.
    @ShanaLMoore
    ShanaLMoore committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    d4d7d29 View commit details
    Browse the repository at this point in the history

  4. 💄 rubocop fixes

    @ShanaLMoore
    ShanaLMoore committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    6d48b29 View commit details
    Browse the repository at this point in the history

Commits on Mar 13, 2024

  1. uncomment #get_s3_files call and add collections to configuration

    @ShanaLMoore
    ShanaLMoore committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    b9bb435 View commit details
    Browse the repository at this point in the history

  2. Update object_factory.rb

    @ShanaLMoore
    ShanaLMoore committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    178349e View commit details
    Browse the repository at this point in the history

  3. ♻️ Move method and remove single instance definition 

    I'm unclear why we were defining methods on the conf instance;
especially given that these exist on the configuration.

With this refactor, we're favoring using the Configuration object as the
container.
    @jeremyf
    jeremyf committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    5ca0411 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'move-method' into i162-import-valkyrie-works-and-filesets

    @ShanaLMoore
    ShanaLMoore committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    844250a View commit details
    Browse the repository at this point in the history

  5. Revert changes due to refactor coming in from main

    @ShanaLMoore
    ShanaLMoore committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    1375a58 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'main' into i162-import-valkyrie-works-and-filesets

    @ShanaLMoore
    ShanaLMoore committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    ee461a6 View commit details
    Browse the repository at this point in the history

Commits on Mar 14, 2024

  1. Merge branch 'hyrax-4-valkyrie-support' into i162-import-valkyrie-wor… 

    …ks-and-filesets
    @ShanaLMoore
    ShanaLMoore committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    bf94442 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'i161-import-collection-resources' into i162-import-valk… 

    …yrie-works-and-filesets
    @ShanaLMoore
    ShanaLMoore committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    3ff48e9 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'hyrax-4-valkyrie-support' into i162-import-valkyrie-wor… 

    …ks-and-filesets
    @ShanaLMoore
    ShanaLMoore committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    c0e9246 View commit details
    Browse the repository at this point in the history

  4. address errors post big refactor

    @ShanaLMoore
    ShanaLMoore committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    341e905 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'i161-import-collection-resources' into i162-import-valk… 

    …yrie-works-and-filesets
    @ShanaLMoore
    ShanaLMoore committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    61ea025 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'hyrax-4-valkyrie-support' into i162-import-valkyrie-wor… 

    …ks-and-filesets

* hyrax-4-valkyrie-support:
  Addressing TODO and minor refactoring
  ♻️ Favor Bulkrax.object_factory and add fault tolerance
    @jeremyf
    jeremyf committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    38770ca View commit details
    Browse the repository at this point in the history

  7. Refactoring for consistent method signatures 

    Also avoiding setting an unused instance variable
    @jeremyf
    jeremyf committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    8ea0388 View commit details
    Browse the repository at this point in the history

  8. 🐛 remove passing user to work_resource add_file_sets and save merge t… 

    …o strategies

Importing a CSV of valkyrie works, collections, files and relationships is working at this point 🎉
    @ShanaLMoore
    ShanaLMoore committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    99118a3 View commit details
    Browse the repository at this point in the history

  9. 🎁 Adding a new transaction step to handle different association

    @jeremyf
    jeremyf committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    bd54be5 View commit details
    Browse the repository at this point in the history

Commits on Mar 15, 2024

  1. ♻️ Extract update_index method to object factory

    @jeremyf
    jeremyf committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    99c712b View commit details
    Browse the repository at this point in the history

  2. ♻️ Extract object factory method

    @jeremyf
    jeremyf committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    b31b5d2 View commit details
    Browse the repository at this point in the history

  3. ♻️ Extract add_resource_to_collection method

    @jeremyf
    jeremyf committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    ce70bd9 View commit details
    Browse the repository at this point in the history

  4. ♻️ XIT out the mockery and stubbery of a spec

    @jeremyf
    jeremyf committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    74a6b40 View commit details
    Browse the repository at this point in the history

  5. ♻️ Extract method publish and add_child_to_parent_work

    @jeremyf
    jeremyf committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    ab86f4c View commit details
    Browse the repository at this point in the history

  6. ♻️ Rename method as it's not conditional 

    Yes, it is conditional but it operates on arrays that could be empty.
    @jeremyf
    jeremyf committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    620c991 View commit details
    Browse the repository at this point in the history

  7. Remove add to collection step

    @jeremyf
    jeremyf committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    267d223 View commit details
    Browse the repository at this point in the history

  8. 🐛 Fix publish parameter mismatch

    @jeremyf
    jeremyf committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    3264490 View commit details
    Browse the repository at this point in the history

  9. Removing custom transaction container. We weren't using it

    @jeremyf
    jeremyf committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    c7f99d1 View commit details
    Browse the repository at this point in the history

  10. Favor keyword args instead of hashes

    @jeremyf
    jeremyf committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    4c9bec1 View commit details
    Browse the repository at this point in the history

  11. 💄fixing typo

    @ShanaLMoore
    ShanaLMoore committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    1f363e1 View commit details
    Browse the repository at this point in the history

  12. 🎁 Add update_collection to valkyrie object factory

    @ShanaLMoore
    ShanaLMoore committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    ea0c95c View commit details
    Browse the repository at this point in the history

  13. 💄 endless and ever appeasing of the coppers

    @jeremyf
    jeremyf committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    2060f69 View commit details
    Browse the repository at this point in the history

  14. Merge branch 'i161-import-collection-resources' into i162-import-valk… 

    …yrie-works-and-filesets

* i161-import-collection-resources:
    @jeremyf
    jeremyf committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    92ba151 View commit details
    Browse the repository at this point in the history