i84 - update visibility label and help text #961
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was contributed back per PALNI PALCI. Since it's possible to override whatever setting the user selects at the form level, help text is provided. If the visibility is declared at the CSV level, the visibility selected at the form level will be ignored. Issue: - scientist-softserv/palni_palci_knapsack#84
laritakr
approved these changes
Jun 18, 2024
ShanaLMoore
commented
Jun 18, 2024
| collection: [ | ||
| ['Public', 'open'], | ||
| ['Private', 'restricted'], | ||
| ['Institution', 'authenticated'] | ||
| ], | ||
| selected: importer.parser_fields['visibility'] || 'open', | ||
| input_html: { class: 'form-control' } | ||
| input_html: { class: 'form-control' }, | ||
| hint: 'If your CSV includes the visibility field, it will override the default setting.' |
There was a problem hiding this comment.
As a first pass, I implemented this following pre-existing bulkrax patterns, which doesn't seem to use locales or support translations.
I will time box my attempt at the translation way.
It seems doable with example,
<%= fi.input :visibility,
label: t('bulkrax.importer.labels.visibility'),
collection: [
['Public', 'open'],
['Private', 'restricted'],
['Institution', 'authenticated']
],
selected: importer.parser_fields['visibility'] || 'open',
input_html: { class: 'form-control' },
hint: t('bulkrax.importer.hints.visibility')
%>
but I will worry about translations at another time since nothing else on this form can be translated anyways.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was contributed back per PALNI PALCI. Since it's possible to override whatever setting the user selects at the form level, help text is provided. If the visibility is declared at the CSV level, the visibility selected at the form level will be ignored.
Issue:
BEFORE
AFTER