Pals Knapsack: Contribute Back to Hyku #2193
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a first pass of the PALs work. There was a lot of head scratching and copying things into Hyku Prime. Together this is a rough process. Related to: - scientist-softserv/palni_palci_knapsack@3595d6f
Co-authored-by: Shana Moore <[email protected]>
Co-authored-by: Kirk Wang <[email protected]>
Co-authored-by: Kirk Wang <[email protected]>
houndci-bot
reviewed
Apr 22, 2024
| flex-direction: column; | ||
|
|
||
| &.active { | ||
| display: flex !important; |
| @keyframes spin { | ||
| 0% { transform: rotate(0deg); } | ||
| 100% { transform: rotate(360deg); } | ||
| } | ||
|
|
||
| #splash { | ||
| display: none; |
There was a problem hiding this comment.
Properties should be ordered align-items, background, display, flex-direction, height, justify-content, left, position, top, width, z-index
| @keyframes spin { | ||
| 0% { transform: rotate(0deg); } | ||
| 100% { transform: rotate(360deg); } | ||
| } | ||
|
|
||
| #splash { |
There was a problem hiding this comment.
Avoid using id selectors
Rule set contains (11/10) properties
| width: 120px; | ||
| height: 120px; | ||
| -webkit-animation: spin 2s linear infinite; /* Safari */ |
1 task
orangewolf
deleted the
62b7d9c5df28e1a576a399e0ebc505e56533fcf4-knapsack
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dupe of: #2178 , sha 62b7d9 due to newly introduced build issues